From: Christoph Hellwig <hch@infradead.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
ext4 hackers <linux-ext4@vger.kernel.org>,
xfs@oss.sgi.com
Subject: Re: NULL pointer dereference in ext4_ext_remove_space on 3.5.1
Date: Fri, 17 Aug 2012 17:05:27 -0400 [thread overview]
Message-ID: <20120817210527.GA22716@infradead.org> (raw)
In-Reply-To: <20120817203438.GA573@thunk.org>
On Fri, Aug 17, 2012 at 04:34:38PM -0400, Theodore Ts'o wrote:
> On Fri, Aug 17, 2012 at 01:48:41PM -0400, Christoph Hellwig wrote:
> >
> > Can you submit this for xfstests?
> >
>
> This is actually something I wanted to ask you guys about. There are
> a series of ext4-specific tests that I could potentially add, but I
> wasn't sure how welcome they would be in xfstests. Assuming that
> ext4-specific tests would be welcome, is there a number range for
> these ext4-specific tests that I should use?
Dave actually has an outstanding series to move tests from the toplevel
directory to directories for categories. We already have a lot of
btrfs-specific tests that have a separate directory, as well as xfs
specific ones, ext4 would just follow this model. For this specific
test it actually seems fairly generic except for the commit interval,
so I'd love to run it for all filesystems, just setting the interval for
ext4.
> BTW, we have an extension to xfstests that we've been using inside
> Google where Google-internal tests have a "g" prefix (i.e., g001,
> g002, etc.). That way we didn't need to worry about conflicts between
> newly added upstream xfstests, and ones which were added internally.
> Would it make sense to start using some kind of prefix such as "e001"
> for ext2/3/4 specific tests?
Can you take a look at Dave's series if that helps you? I haven't
really reviewed it much myself yet, but I'll try to get to it ASAP.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-08-17 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABRT9RAOhaxcYdCxMn5neJ9WT85r=h=7WgZ2dmLaOs-MMqDW9A@mail.gmail.com>
[not found] ` <20120816024654.GB3781@thunk.org>
[not found] ` <20120816111051.GA16036@localhost>
[not found] ` <20120816152513.GA31346@thunk.org>
[not found] ` <20120817060110.GA28786@localhost>
[not found] ` <20120817131558.GA11439@thunk.org>
[not found] ` <20120817174841.GA4519@infradead.org>
2012-08-17 20:34 ` NULL pointer dereference in ext4_ext_remove_space on 3.5.1 Theodore Ts'o
2012-08-17 21:05 ` Christoph Hellwig [this message]
2012-08-17 22:55 ` Dave Chinner
2012-08-17 23:11 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817210527.GA22716@infradead.org \
--to=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox