From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "Bill Kendall" <wkendall@sgi.com>,
=?UTF-8?B?QXJrYWRpdXN6IE1pxZtraWV3aWM=?=@oss.sgi.com,
"Boris Ranto" <branto@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsdump: save & restore 32-bit projids
Date: Mon, 27 Aug 2012 10:35:55 +1000 [thread overview]
Message-ID: <20120827003555.GB13691@dastard> (raw)
In-Reply-To: <503ABD37.7090006@redhat.com>
On Sun, Aug 26, 2012 at 07:20:07PM -0500, Eric Sandeen wrote:
> Current xfsdump/xfsrestore only recognize the lower 16 bits of the projid.
> With this patch, the full 32 bits are dumped & restored.
>
> Reported-by: Boris Ranto <branto@redhat.com>
> Cc: Arkadiusz Miśkiewicz <arekm@maven.pl>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> This also adds a definition for bs_forkoff, but I don't think
> that is something which should get saved & restored, correct?
Right - it's a kernel controlled field, only exported as a hint to
help xfs_fsr build similarly formatted inodes.
> TBH I've done very little hacking on xfsdump. I think this
> requires a new version, but not sure. This seems to work but
> may need sanity checks & fixups. And, of course, an xfstest.
Looks ok, but I'm in the same boat as you on xfsdump. A QA test
would be good to go along with this. ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-08-27 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 0:20 [PATCH] xfsdump: save & restore 32-bit projids Eric Sandeen
2012-08-27 0:35 ` Dave Chinner [this message]
2012-08-27 3:27 ` [PATCH] xfstests: test dump/restore of " Eric Sandeen
2012-09-18 20:44 ` [PATCH] xfsdump: save & restore " Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120827003555.GB13691@dastard \
--to=david@fromorbit.com \
--cc==?UTF-8?B?QXJrYWRpdXN6IE1pxZtraWV3aWM=?=@oss.sgi.com \
--cc=branto@redhat.com \
--cc=sandeen@redhat.com \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox