public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Rich Johnston <rjohnston@sgi.com>
Cc: xfs@oss.sgi.com
Subject: [PATCH 3/5] xftests: Use installed libraries only
Date: Tue, 28 Aug 2012 12:26:08 -0500	[thread overview]
Message-ID: <20120828172929.203767140@sgi.com> (raw)
In-Reply-To: 20120828172605.607853317@sgi.com

[-- Attachment #1: 3-5-xfstests-remove-relative-lib-paths.patch --]
[-- Type: text/plain, Size: 4068 bytes --]

The xfstests autotools currently searches locally in
   ../{acl,attr,dmapi,xfsprogs}
for libraries that xfstests depends upon, in addition to searching for them in
their regular installed locations on a system, e.g. /usr/lib.  It appears this
feature was added (but not documented) so that xfs developers can build and run
xfstests without having to install the libraries.  This can lead to touble if
you expect that xfstests is using the versions of the libraries installed on
the system.

If a local library was found and not installed, libtool will create a wrapper
script to call the binary from the .libs directory.  This patch will remove
searching for local libraies so that the installed libraries are always used.

Signed-off-by: Rich Johnston <rjohnston@sgi.com>

---
 m4/package_acldev.m4   |    2 --
 m4/package_attrdev.m4  |    4 ----
 m4/package_dmapidev.m4 |    2 --
 m4/package_xfslibs.m4  |    6 ------
 4 files changed, 14 deletions(-)

Index: b/m4/package_acldev.m4
===================================================================
--- a/m4/package_acldev.m4
+++ b/m4/package_acldev.m4
@@ -30,8 +30,6 @@ AC_DEFUN([AC_PACKAGE_NEED_ACLINIT_LIBACL
         exit 1
     ])
     libacl="-lacl"
-    test -f `pwd`/../acl/libacl/libacl.la && \
-        libacl="`pwd`/../acl/libacl/libacl.la"
     test -f ${libexecdir}${libdirsuffix}/libacl.la && \
 	libacl="${libexecdir}${libdirsuffix}/libacl.la"
     AC_SUBST(libacl)
Index: b/m4/package_attrdev.m4
===================================================================
--- a/m4/package_attrdev.m4
+++ b/m4/package_attrdev.m4
@@ -46,8 +46,6 @@ AC_DEFUN([AC_PACKAGE_NEED_GETXATTR_LIBAT
         exit 1
     ])
     libattr="-lattr"
-    test -f `pwd`/../attr/libattr/libattr.la && \
-        libattr="`pwd`/../attr/libattr/libattr.la"
     test -f ${libexecdir}${libdirsuffix}/libattr.la && \
 	libattr="${libexecdir}${libdirsuffix}/libattr.la"
     AC_SUBST(libattr)
@@ -62,8 +60,6 @@ AC_DEFUN([AC_PACKAGE_NEED_ATTRGET_LIBATT
         exit 1
     ])
     libattr="-lattr"
-    test -f `pwd`/../attr/libattr/libattr.la && \
-        libattr="`pwd`/../attr/libattr/libattr.la"
     test -f ${libexecdir}${libdirsuffix}/libattr.la && \
 	libattr="${libexecdir}${libdirsuffix}/libattr.la"
     AC_SUBST(libattr)
Index: b/m4/package_dmapidev.m4
===================================================================
--- a/m4/package_dmapidev.m4
+++ b/m4/package_dmapidev.m4
@@ -20,8 +20,6 @@ AC_DEFUN([AC_PACKAGE_WANT_DMAPI],
 	echo
     ])
     libdm="-ldm"
-    test -f `pwd`/../dmapi/libdm/libdm.la && \
-        libdm="`pwd`/../dmapi/libdm/libdm.la"
     test -f ${libexecdir}${libdirsuffix}/libdm.la && \
 	libdm="${libexecdir}${libdirsuffix}/libdm.la"
     AC_SUBST(libdm)
Index: b/m4/package_xfslibs.m4
===================================================================
--- a/m4/package_xfslibs.m4
+++ b/m4/package_xfslibs.m4
@@ -51,8 +51,6 @@ AC_DEFUN([AC_PACKAGE_NEED_LIBXFSINIT_LIB
         exit 1
     ])
     libxfs="-lxfs"
-    test -f `pwd`/../xfsprogs/libxfs/libxfs.la && \
-        libxfs="`pwd`/../xfsprogs/libxfs/libxfs.la"
     test -f ${libexecdir}${libdirsuffix}/libxfs.la && \
 	libxfs="${libexecdir}${libdirsuffix}/libxfs.la"
     AC_SUBST(libxfs)
@@ -67,8 +65,6 @@ AC_DEFUN([AC_PACKAGE_NEED_OPEN_BY_FSHAND
         exit 1
     ])
     libhdl="-lhandle"
-    test -f `pwd`/../xfsprogs/libhandle/libhandle.la && \
-        libhdl="`pwd`/../xfsprogs/libhandle/libhandle.la"
     test -f ${libexecdir}${libdirsuffix}/libhandle.la && \
 	libhdl="${libexecdir}${libdirsuffix}/libhandle.la"
     AC_SUBST(libhdl)
@@ -83,8 +79,6 @@ AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHA
         exit 1
     ])
     libhdl="-lhandle"
-    test -f `pwd`/../xfsprogs/libhandle/libhandle.la && \
-        libhdl="`pwd`/../xfsprogs/libhandle/libhandle.la"
     test -f ${libexecdir}${libdirsuffix}/libhandle.la && \
 	libhdl="${libexecdir}${libdirsuffix}/libhandle.la"
     AC_SUBST(libhdl)

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2012-08-28 17:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28 17:26 [PATCH 0/5] Use libtool to install apps and remove relative lib paths Rich Johnston
2012-08-28 17:26 ` [PATCH 1/5] xfstests: Use libtool to install lstat64 Rich Johnston
2012-09-03  5:31   ` Dave Chinner
2012-08-28 17:26 ` [PATCH 2/5] xfstests: Use libtool to install applications Rich Johnston
2012-09-03  5:36   ` Dave Chinner
2013-04-16 15:54   ` Boris Ranto
2013-04-17 14:51     ` Rich Johnston
2013-04-17 15:56       ` Eric Sandeen
2013-04-18 12:25       ` Boris Ranto
2013-04-18 12:46         ` Greg Freemyer
2013-04-18 13:37           ` Boris Ranto
2012-08-28 17:26 ` Rich Johnston [this message]
2012-09-03  5:37   ` [PATCH 3/5] xftests: Use installed libraries only Dave Chinner
2012-08-28 17:26 ` [PATCH 4/5] dmapi: " Rich Johnston
2012-09-03  5:38   ` Dave Chinner
2012-08-28 17:26 ` [PATCH 5/5] xfsdump: " Rich Johnston
2012-09-03  5:39   ` Dave Chinner
2012-09-04 16:07 ` [PATCH 0/5] Use libtool to install apps and remove relative lib paths Ben Myers
2012-09-06 18:43   ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120828172929.203767140@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox