From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7SJq5vo141835 for ; Tue, 28 Aug 2012 14:52:05 -0500 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id Bari7qnPmFHbPSVo (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Tue, 28 Aug 2012 12:52:56 -0700 (PDT) Date: Tue, 28 Aug 2012 15:52:54 -0400 From: Christoph Hellwig Subject: Re: [PATCH 06/18] xfstests: clean up and simply check CLI option parsing Message-ID: <20120828195254.GE15060@infradead.org> References: <1343294892-20991-1-git-send-email-david@fromorbit.com> <1343294892-20991-7-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1343294892-20991-7-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Thu, Jul 26, 2012 at 07:28:00PM +1000, Dave Chinner wrote: > From: Dave Chinner > > The option parise in a messy loop of option parsing and actions on > secondary arguments. Turn it into something much neater and esay to > understand rather than a mess of temporary variables and tortured > logic... > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs