public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Mark Tinguely <tinguely@sgi.com>
Cc: Ben Myers <bpm@sgi.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: flush workers before stopping log
Date: Sat, 1 Sep 2012 19:08:24 -0400	[thread overview]
Message-ID: <20120901230824.GB6896@infradead.org> (raw)
In-Reply-To: <5040FF25.1010501@sgi.com>

On Fri, Aug 31, 2012 at 01:15:01PM -0500, Mark Tinguely wrote:
> I see your point on fixing problems in older branches when/if they
> are reported by an user. I am not glowing with pride with the patch,
> it is something that survived a week of testing that would cause a
> panic in a couple hours without the patch. Since we hit this problem
> with such frequency, that we wanted to push for a little proactive
> attention to prevent future panics.

I'd love to see a relatively minimal patch which can also be backported.
I also have to say that your patch as-is scares me a bit.  Everytime we
move the current xfs_sync_init/stop monsters around we created another
set of problems.  So I'd prefer at least taking the bits from Dave's
series that kill these helpers and do individual calls, and only move
those that are needed.   The other thing that I don't like about the
patch is that it causes assymetry in the mount/unmount path by moving
the stop into xfs_unmountfs but not the start into xfs_mountfs.  That
might be needed in some cases, but that should be some detailed comments
explaining why.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-09-01 23:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120829134624.316257238@sgi.com>
2012-08-29 13:46 ` [PATCH] xfs: flush workers before stopping log tinguely
2012-08-29 14:31   ` Mark Tinguely
2012-08-30  0:23   ` Dave Chinner
2012-08-30 17:25     ` Ben Myers
2012-08-30 22:35       ` Dave Chinner
2012-08-31 18:15         ` Mark Tinguely
2012-09-01 23:08           ` Christoph Hellwig [this message]
2012-09-12 18:33             ` xfs: stop the sync worker before xfs_unmountfs Ben Myers
2012-09-12 23:14               ` Dave Chinner
2012-09-13 16:43                 ` Ben Myers
2012-09-13 21:18                   ` [PATCH] " Ben Myers
2012-09-14  1:07                     ` Dave Chinner
2012-09-18 13:28                     ` Mark Tinguely
2012-09-13  8:17               ` Christoph Hellwig
2012-09-13 21:19                 ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120901230824.GB6896@infradead.org \
    --to=hch@infradead.org \
    --cc=bpm@sgi.com \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox