public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Ben Myers <bpm@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [RFC, PATCH 0/102]: xfs: 3.0.x stable kernel update
Date: Wed, 5 Sep 2012 14:24:29 +1000	[thread overview]
Message-ID: <20120905042429.GD15292@dastard> (raw)
In-Reply-To: <20120904211357.GK3274@sgi.com>

On Tue, Sep 04, 2012 at 04:13:57PM -0500, Ben Myers wrote:
> On Mon, Sep 03, 2012 at 04:04:06PM +1000, Dave Chinner wrote:
> > On Sat, Sep 01, 2012 at 07:10:19PM -0400, Christoph Hellwig wrote:
> > > I've done a brief look over the patches this week and while I can't spot
> > > anything wrong I'm defintively a bit concerned about the amount of churn
> > > for a long term stable series.  A lot of this does not seem to fit the
> > > strict -stable criteria, and given that I've not really seen any major
> > > issues with the current 3.0-stable codebase I'm wondering what the
> > > guranteed gain vs the status quo is.
> > 
> > You didn't troll the RH bugzilla ;)
> 
> Hehe.  ;)
> 
> > The XFS code base in RHEL6 is sitting at 3.0, and several of the
> > problems that have workarounds in 3.0.x don't fix the problems
> > reported (e.g. the log space hangs), while the fixes in the more
> > recent mainline kernel do.
> > 
> > I simply figured that I've got to do this much work to fix all the
> > bugs reported in RHEL6 and given the code bases are almost identical
> > I'd do a community service and push it to 3.0.x first. I'm quite
> > happy not to push it to 3.0.x if the consensus is that it is too
> > much churn.
> 
> FWIW I think it's great that you've done the community this service.
> I'm just now (finally) getting this patchset onto a machine for some
> testing.
> 
> Ok.. now that I've refreshed my memory of
> Documentation/stable_kernel_rules.txt, I can see Christoph's point.
> Some of these patches are hard to justify based upon those rules.  For
> example:
> 
> Patch 2, 'remove dead ENODEV handling in xfs_destroy_ioend' seems to
> just remove some dead code.  However, if it were clear that it fixes
> some kind of problem by removing the dead code it could easily be
> justified.

The are several patches in the series touch xfs_destroy_ioend().
Having to resolve all the conflicts by hand instead of including the
patch that removes the 5 lines of dead code means I didn't have to
modify the patches when applying them, and the result is verifiably
identical to the code in the current mainline tree...

Indeed, the very next patch would not apply without patch 2....

> Patch 94, 'm_maxioffset is redundant' seems like a cleanup.  But maybe
> it is required so that a subsequent patch will apply properly?
> 
> Patch 95, 'make largest supported offset less shouty' just cleans up a
> macro.  Again... maybe there is a good reason to pull that in besides
> the shouting.

Yeah, 94/95 can go. What probably happened there was that I was
considering a later patch that was dependent on these changes and I
ended up dropping that patch without realising I then didn't need
the m_maxioffset changes.

> So there are three examples that would probably require some kind of
> justification to apply within the rules as stated.  Maybe -stable just
> needs a link to the bug each one of them resolves.
> 
> It looks like there are plenty in the patchset that are very clearly
> appropriate within the rules, no additional justification required.  We
> certainly don't want to lose that.  We can go through the set and reply
> to those which seem questionable...

Sure, but remember that the dependent patches might be 50 patches
later in the series as the patches are applied in upstream commit
order....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-09-05  4:23 UTC|newest]

Thread overview: 117+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23  5:01 [RFC, PATCH 0/102]: xfs: 3.0.x stable kernel update Dave Chinner
2012-08-23  5:01 ` [PATCH 001/102] xfs: don't serialise adjacent concurrent direct IO appending writes Dave Chinner
2012-08-23  5:01 ` [PATCH 002/102] xfs: remove dead ENODEV handling in xfs_destroy_ioend Dave Chinner
2012-08-23  5:01 ` [PATCH 003/102] xfs: defer AIO/DIO completions Dave Chinner
2012-08-23  5:01 ` [PATCH 004/102] xfs: reduce ioend latency Dave Chinner
2012-08-23  5:01 ` [PATCH 005/102] xfs: wait for I/O completion when writing out pages in xfs_setattr_size Dave Chinner
2012-08-23  5:01 ` [PATCH 006/102] xfs: improve ioend error handling Dave Chinner
2012-08-23  5:01 ` [PATCH 007/102] xfs: Check the return value of xfs_buf_get() Dave Chinner
2012-08-23  5:01 ` [PATCH 008/102] xfs: Check the return value of xfs_trans_get_buf() Dave Chinner
2012-08-23  5:01 ` [PATCH 009/102] xfs: dont ignore error code from xfs_bmbt_update Dave Chinner
2012-08-23  5:01 ` [PATCH 010/102] xfs: fix possible overflow in xfs_ioc_trim() Dave Chinner
2012-08-23  5:01 ` [PATCH 011/102] xfs: XFS_TRANS_SWAPEXT is not a valid flag for Dave Chinner
2012-08-23  5:01 ` [PATCH 012/102] xfs: Don't allocate new buffers on every call to _xfs_buf_find Dave Chinner
2012-08-23  5:01 ` [PATCH 013/102] xfs: reduce the number of log forces from tail pushing Dave Chinner
2012-08-23  5:01 ` [PATCH 014/102] xfs: optimize fsync on directories Dave Chinner
2012-08-23  5:01 ` [PATCH 015/102] xfs: clean up buffer allocation Dave Chinner
2012-08-23  5:01 ` [PATCH 016/102] xfs: clean up xfs_ioerror_alert Dave Chinner
2012-08-23  5:01 ` [PATCH 017/102] xfs: use xfs_ioerror_alert in xfs_buf_iodone_callbacks Dave Chinner
2012-08-23  5:01 ` [PATCH 018/102] xfs: do not flush data workqueues in xfs_flush_buftarg Dave Chinner
2012-08-23  5:01 ` [PATCH 019/102] xfs: add AIL pushing tracepoints Dave Chinner
2012-08-23  5:01 ` [PATCH 020/102] xfs: warn if direct reclaim tries to writeback pages Dave Chinner
2012-08-27 18:17   ` Christoph Hellwig
2012-09-05 11:32     ` Mel Gorman
2012-09-13 20:12       ` Mark Tinguely
2012-09-14  9:45         ` Mel Gorman
2012-09-14 12:56           ` Mark Tinguely
2012-09-14 16:18             ` Mark Tinguely
2012-08-23  5:01 ` [PATCH 021/102] xfs: fix force shutdown handling in xfs_end_io Dave Chinner
2012-08-23  5:01 ` [PATCH 022/102] xfs: fix allocation length overflow in xfs_bmapi_write() Dave Chinner
2012-08-23  5:01 ` [PATCH 023/102] xfs: fix the logspace waiting algorithm Dave Chinner
2012-08-23  5:01 ` [PATCH 024/102] xfs: untangle SYNC_WAIT and SYNC_TRYLOCK meanings for xfs_qm_dqflush Dave Chinner
2012-08-23  5:01 ` [PATCH 025/102] xfs: make sure to really flush all dquots in xfs_qm_quotacheck Dave Chinner
2012-08-23  5:01 ` [PATCH 026/102] xfs: simplify xfs_qm_detach_gdquots Dave Chinner
2012-08-23  5:01 ` [PATCH 027/102] xfs: mark the xfssyncd workqueue as non-reentrant Dave Chinner
2012-08-23  5:01 ` [PATCH 028/102] xfs: make i_flags an unsigned long Dave Chinner
2012-08-23  5:01 ` [PATCH 029/102] xfs: remove the i_size field in struct xfs_inode Dave Chinner
2012-08-23  5:01 ` [PATCH 030/102] xfs: remove the i_new_size " Dave Chinner
2012-08-23  5:01 ` [PATCH 031/102] xfs: always return with the iolock held from Dave Chinner
2012-08-23  5:01 ` [PATCH 032/102] xfs: cleanup xfs_file_aio_write Dave Chinner
2012-08-23  5:01 ` [PATCH 033/102] xfs: pass KM_SLEEP flag to kmem_realloc() in Dave Chinner
2012-08-23  5:01 ` [PATCH 034/102] xfs: show uuid when mount fails due to duplicate uuid Dave Chinner
2012-08-23  5:01 ` [PATCH 035/102] xfs: xfs_trans_add_item() - don't assign in ASSERT() when compare is intended Dave Chinner
2012-08-23  5:01 ` [PATCH 036/102] xfs: split tail_lsn assignments from log space wakeups Dave Chinner
2012-08-23  5:01 ` [PATCH 037/102] xfs: do exact log space wakeups in xlog_ungrant_log_space Dave Chinner
2012-08-23  5:01 ` [PATCH 038/102] xfs: remove xfs_trans_unlocked_item Dave Chinner
2012-08-23  5:01 ` [PATCH 039/102] xfs: cleanup xfs_log_space_wake Dave Chinner
2012-08-23  5:01 ` [PATCH 040/102] xfs: remove log space waitqueues Dave Chinner
2012-08-23  5:01 ` [PATCH 041/102] xfs: add the xlog_grant_head structure Dave Chinner
2012-08-23  5:02 ` [PATCH 042/102] xfs: add xlog_grant_head_init Dave Chinner
2012-08-23  5:02 ` [PATCH 043/102] xfs: add xlog_grant_head_wake_all Dave Chinner
2012-08-23  5:02 ` [PATCH 044/102] xfs: share code for grant head waiting Dave Chinner
2012-08-23  5:02 ` [PATCH 045/102] xfs: share code for grant head wakeups Dave Chinner
2012-08-23  5:02 ` [PATCH 046/102] xfs: share code for grant head availability checks Dave Chinner
2012-08-23  5:02 ` [PATCH 047/102] xfs: split and cleanup xfs_log_reserve Dave Chinner
2012-08-23  5:02 ` [PATCH 048/102] xfs: only take the ILOCK in xfs_reclaim_inode() Dave Chinner
2012-08-23  5:02 ` [PATCH 049/102] xfs: use per-filesystem I/O completion workqueues Dave Chinner
2012-08-23  5:02 ` [PATCH 050/102] xfs: do not require an ioend for new EOF calculation Dave Chinner
2012-08-23  5:02 ` [PATCH 054/102] xfs: make xfs_inode_item_size idempotent Dave Chinner
2012-08-23  5:02 ` [PATCH 055/102] xfs: split in-core and on-disk inode log item fields Dave Chinner
2012-08-23  5:02 ` [PATCH 056/102] xfs: reimplement fdatasync support Dave Chinner
2012-08-23  5:02 ` [PATCH 057/102] xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get Dave Chinner
2012-08-23  5:02 ` [PATCH 058/102] xfs: fallback to vmalloc for large buffers in xfs_getbmap Dave Chinner
2012-08-23  5:02 ` [PATCH 059/102] xfs: fix deadlock in xfs_rtfree_extent Dave Chinner
2012-08-23  5:02 ` [PATCH 060/102] xfs: Fix open flag handling in open_by_handle code Dave Chinner
2012-08-23  5:02 ` [PATCH 061/102] xfs: introduce an allocation workqueue Dave Chinner
2012-08-23  5:02 ` [PATCH 062/102] xfs: trace xfs_name strings correctly Dave Chinner
2012-08-23  5:02 ` [PATCH 063/102] xfs: Account log unmount transaction correctly Dave Chinner
2012-08-23  5:02 ` [PATCH 064/102] xfs: fix fstrim offset calculations Dave Chinner
2012-08-23  5:02 ` [PATCH 065/102] xfs: add lots of attribute trace points Dave Chinner
2012-08-23  5:02 ` [PATCH 066/102] xfs: don't fill statvfs with project quota for a directory Dave Chinner
2012-08-23  5:02 ` [PATCH 067/102] xfs: Ensure inode reclaim can run during quotacheck Dave Chinner
2012-08-23  5:02 ` [PATCH 068/102] xfs: avoid taking the ilock unnessecarily in xfs_qm_dqattach Dave Chinner
2012-08-23  5:02 ` [PATCH 069/102] xfs: reduce ilock hold times in xfs_file_aio_write_checks Dave Chinner
2012-08-23  5:02 ` [PATCH 070/102] xfs: reduce ilock hold times in xfs_setattr_size Dave Chinner
2012-08-23  5:02 ` [PATCH 071/102] xfs: push the ilock into xfs_zero_eof Dave Chinner
2012-08-23  5:02 ` [PATCH 072/102] xfs: use shared ilock mode for direct IO writes by default Dave Chinner
2012-08-23  5:02 ` [PATCH 073/102] xfs: punch all delalloc blocks beyond EOF on write failure Dave Chinner
2012-08-23  5:02 ` [PATCH 074/102] xfs: using GFP_NOFS for blkdev_issue_flush Dave Chinner
2012-08-23  5:02 ` [PATCH 075/102] xfs: page type check in writeback only checks last buffer Dave Chinner
2012-08-23  5:02 ` [PATCH 076/102] xfs: punch new delalloc blocks out of failed writes inside Dave Chinner
2012-08-23  5:02 ` [PATCH 077/102] xfs: prevent needless mount warning causing test failures Dave Chinner
2012-08-23  5:02 ` [PATCH 078/102] xfs: don't assert on delalloc regions beyond EOF Dave Chinner
2012-08-23  5:02 ` [PATCH 079/102] xfs: limit specualtive delalloc to maxioffset Dave Chinner
2012-08-23  5:02 ` [PATCH 080/102] xfs: Use preallocation for inodes with extsz hints Dave Chinner
2012-08-23  5:02 ` [PATCH 081/102] xfs: fix buffer lookup race on allocation failure Dave Chinner
2012-08-23  5:02 ` [PATCH 082/102] xfs: check for buffer errors before waiting Dave Chinner
2012-08-23  5:02 ` [PATCH 083/102] xfs: fix incorrect b_offset initialisation Dave Chinner
2012-08-23  5:02 ` [PATCH 084/102] xfs: use kmem_zone_zalloc for buffers Dave Chinner
2012-08-23  5:02 ` [PATCH 085/102] xfs: use iolock on XFS_IOC_ALLOCSP calls Dave Chinner
2012-08-23  5:02 ` [PATCH 086/102] xfs: Properly exclude IO type flags from buffer flags Dave Chinner
2012-08-23  5:02 ` [PATCH 087/102] xfs: flush outstanding buffers on log mount failure Dave Chinner
2012-08-23  5:02 ` [PATCH 088/102] xfs: protect xfs_sync_worker with s_umount semaphore Dave Chinner
2012-08-23  5:02 ` [PATCH 089/102] xfs: fix memory reclaim deadlock on agi buffer Dave Chinner
2012-08-23  5:02 ` [PATCH 090/102] xfs: add trace points for log forces Dave Chinner
2012-08-23  5:02 ` [PATCH 091/102] xfs: switch to proper __bitwise type for KM_... flags Dave Chinner
2012-08-23  5:02 ` [PATCH 092/102] xfs: xfs_vm_writepage clear iomap_valid when Dave Chinner
2012-08-23  5:02 ` [PATCH 093/102] xfs: fix debug_object WARN at xfs_alloc_vextent() Dave Chinner
2012-08-23  5:02 ` [PATCH 094/102] xfs: m_maxioffset is redundant Dave Chinner
2012-08-23  5:02 ` [PATCH 095/102] xfs: make largest supported offset less shouty Dave Chinner
2012-08-23  5:02 ` [PATCH 096/102] xfs: kill copy and paste segment checks in xfs_file_aio_read Dave Chinner
2012-08-23  5:02 ` [PATCH 097/102] xfs: fix allocbt cursor leak in xfs_alloc_ag_vextent_near Dave Chinner
2012-08-23  5:02 ` [PATCH 098/102] xfs: shutdown xfs_sync_worker before the log Dave Chinner
2012-08-23  5:02 ` [PATCH 099/102] xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near Dave Chinner
2012-08-23  5:02 ` [PATCH 100/102] xfs: don't defer metadata allocation to the workqueue Dave Chinner
2012-08-23  5:02 ` [PATCH 101/102] xfs: prevent recursion in xfs_buf_iorequest Dave Chinner
2012-08-23  5:03 ` [PATCH 102/102] xfs: handle EOF correctly in xfs_vm_writepage Dave Chinner
2012-08-23 21:54 ` [RFC, PATCH 0/102]: xfs: 3.0.x stable kernel update Dave Chinner
2012-08-23 22:14   ` Ben Myers
2012-08-23 22:23   ` Matthias Schniedermeyer
2012-09-01 23:10 ` Christoph Hellwig
2012-09-03  6:04   ` Dave Chinner
2012-09-04 21:13     ` Ben Myers
2012-09-05  4:24       ` Dave Chinner [this message]
2012-09-13 18:32 ` Mark Tinguely
2012-09-18 13:59 ` Mark Tinguely
2012-09-18 23:50   ` Dave Chinner
2012-09-19 13:14     ` Mark Tinguely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120905042429.GD15292@dastard \
    --to=david@fromorbit.com \
    --cc=bpm@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox