From: Ben Myers <bpm@sgi.com>
To: rjohnston@sgi.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 11/10] xfstests: rework large filesystem testing - add golden output
Date: Wed, 5 Sep 2012 16:34:26 -0500 [thread overview]
Message-ID: <20120905213426.GL3274@sgi.com> (raw)
In-Reply-To: <1343291989-14987-1-git-send-email-david@fromorbit.com>
Hey Rich,
On Fri, Aug 31, 2012 at 02:43:27PM -0500, rjohnston@sgi.com wrote:
> Patch "rework large filesystem testing" introduces a new option --large-fs
> which creates a new file $SCRATCH_MNT/.use_space. If this 10 part patchset is
> applied, the following tests will fail:
> 019 026 027 028 046 047 050 056 059 060 062 063 064 065 066
>
> This patch accounts for the following new output when testing xfs filesystems with
> the --large-fs option by creating new output file to compare against
> ($seq.largefs.out):
>
> 1. The following four lines appear in test 019.
> File: "./.use_space"
> Size: 6312890368 Filetype: Regular File
> Mode: (0600/-rw-------) Uid: (0) Gid: (0)
> Device: <DEVICE> Inode: <INODE> Links: 1
>
> 2. When the nodump attribute is set, the xfsdump -e option will cause the
> following additional lines to appear.
> xfsdump: NOTE: pruned 1 files: skip attribute set
> Only in SCRATCH_MNT: .use_space
> SCRATCH_MNT/.use_space
>
> 3. Number of files off by one.
> xfsrestore: # directories and (off by 1) entries processed
> [ROOT] 0 0 0 00 [--------] (off by 1) 0 0 00 [--------] 0 0 0 00 [--------]
>
> This patch also modifies check and common.quota to use the new output file
> $seq.largefs.out when the --large-fs option is used (LARGE_SCRATCH_DEV = yes)
> or $seq.out when the --large-fs option is NOT used (LARGE_SCRATCH_DEV != yes).
>
> Signed-off-by: Rich Johnston <rjohnston@sgi.com>
This looks pretty good to me. .use_space changed some golden output and you've
fixed that up by adding additional output files for when this --large-fs option
is used. Dave will probably want to take a look too.
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-05 21:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120831194326.741195404@sgi.com>
2012-07-26 8:39 ` [PATCH 0/10] xfstests: rework large filesystem testing Dave Chinner
2012-07-26 8:39 ` [PATCH 01/10] xfstests: add --largefs check option Dave Chinner
2012-08-28 14:00 ` Rich Johnston
2012-08-28 19:56 ` Christoph Hellwig
2012-07-26 8:39 ` [PATCH 02/10] xfstests: rename USE_BIG_LOOPFS to be more generic Dave Chinner
2012-08-28 14:01 ` Rich Johnston
2012-08-31 23:30 ` Dave Chinner
2012-08-28 19:56 ` Christoph Hellwig
2012-07-26 8:39 ` [PATCH 03/10] xfstests: rename RETAIN_AG_BYTES Dave Chinner
2012-08-28 14:01 ` Rich Johnston
2012-08-28 19:56 ` Christoph Hellwig
2012-07-26 8:39 ` [PATCH 04/10] xfstests: use preallocation for ag-wiper Dave Chinner
2012-08-28 14:02 ` Rich Johnston
2012-08-28 19:57 ` Christoph Hellwig
2012-07-26 8:39 ` [PATCH 05/10] xfstests: use command line option for setting extra space Dave Chinner
2012-08-28 14:02 ` Rich Johnston
2012-08-28 19:57 ` Christoph Hellwig
2012-07-26 8:39 ` [PATCH 06/10] xfstest: enable xfs_repair for large filesystem testing Dave Chinner
2012-08-28 14:02 ` Rich Johnston
2012-08-28 19:58 ` Christoph Hellwig
2012-07-26 8:39 ` [PATCH 07/10] xfstests: always us test option when checking large scratch device Dave Chinner
2012-07-26 17:21 ` Paulo Alcantara
2012-08-28 14:02 ` Rich Johnston
2012-08-28 19:58 ` Christoph Hellwig
2012-07-26 8:39 ` [PATCH 08/10] xfstests: enable large fs testing on ext4 Dave Chinner
2012-08-28 20:03 ` Christoph Hellwig
2012-09-05 16:27 ` Rich Johnston
2012-07-26 8:39 ` [PATCH 09/10] xfstests: disable tests that typically fail on large filesystems Dave Chinner
2012-08-28 14:03 ` Rich Johnston
2012-08-28 20:03 ` Christoph Hellwig
2012-07-26 8:39 ` [PATCH 10/10] xfstests: exclude largefs fill files from dump tests Dave Chinner
2012-08-28 14:03 ` Rich Johnston
2012-08-28 20:04 ` Christoph Hellwig
2012-08-14 21:40 ` [PATCH 0/10] xfstests: rework large filesystem testing Dave Chinner
2012-09-05 21:34 ` Ben Myers [this message]
2012-09-05 22:26 ` [PATCH 11/10] xfstests: rework large filesystem testing - add golden output Dave Chinner
2012-09-06 12:57 ` Rich Johnston
2012-09-06 23:07 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905213426.GL3274@sgi.com \
--to=bpm@sgi.com \
--cc=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox