Re: [PATCH v3] Add test case to test xfs projid32bit functionality a bit more extensively.

Dave Chinner
2012-09-11T03:44:11Z

On Mon, Sep 10, 2012 at 09:47:03PM -0500, Eric Sandeen wrote:
> On 9/6/12 10:23 AM, Boris Ranto wrote:
> > The test covers several areas including enabling projid32bit
> > functionality dynamically by xfs_admin, dumping, restoring, quota
> > reporting and xfs_db projid values reporting.
> > This test case hits a bug with xfsdump/xfsrestore process on a
> > projid32bit enabled filesystem.
> >
> > Signed-off-by: Boris Ranto <ranto.boris@gmail.com>
>
> there are just a couple things below, but I think we can get it
> checked in unless Dave has further concerns - please see below.
....
> > +dir=$SCRATCH_MNT/pquota
> > +
> > +status=1
> > +
> > +mkdir -p $dir
> > +touch $dir/{16,32}less
>
> Although I understand it ok, I might add a comment here saying:
>
> # create files to hold 16 and 32-bit project IDs
>
> In retrospect I might use 16bit and 32bit to make more sense.
> Sorry, should have suggested that earlier.
>
> I could just change the names on checkin with a note if that's ok with you.

With that change to 16bit/32bit, it's fine by me.

> > @@ -403,3 +403,4 @@ deprecated
> > 282 dump ioctl auto quick
> > 283 dump ioctl auto quick
> > 284 auto
> > +285 auto dump quota

Like I mentione dfirst time around, it needs to be added to the
quick group as well.

If you make those changes, Eric, then consider it:

Reviewed-by: Dave Chinner <dchinner@redhat.com>

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com