From: Christoph Hellwig <hch@infradead.org>
To: raghu.prabhu13@gmail.com
Cc: Raghavendra D Prabhu <rprabhu@wnohang.net>, xfs@oss.sgi.com
Subject: Re: [PATCH v6] Stop periodic syncing if filesystem is already shutdown.
Date: Tue, 25 Sep 2012 05:40:13 -0400 [thread overview]
Message-ID: <20120925094013.GI9189@infradead.org> (raw)
In-Reply-To: <143becf0f8266fbc8025ec97c8f44476d8fcafc5.1348203015.git.rprabhu@wnohang.net>
Looks good, but one thing I'd love here is to actually print a useful
error for the typical EIO case, as the "error 5 occured" message just
confuses the heck out of people. What it means is that we got an
EIO error from the block device, and that's what we should print.
Probably worth doing in a separate patch, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-25 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 4:54 [PATCH v6] Stop periodic syncing if filesystem is already shutdown raghu.prabhu13
2012-09-21 13:42 ` Carlos Maiolino
2012-09-25 9:40 ` Christoph Hellwig [this message]
2012-10-24 20:57 ` Raghavendra Prabhu
2012-10-24 22:10 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925094013.GI9189@infradead.org \
--to=hch@infradead.org \
--cc=raghu.prabhu13@gmail.com \
--cc=rprabhu@wnohang.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox