From: Carlos Maiolino <cmaiolino@redhat.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH 4/6] xfs: Fix mp->m_maxagi update during inode64 remount
Date: Tue, 25 Sep 2012 10:33:29 -0300 [thread overview]
Message-ID: <20120925133329.GA10780@andromeda.usersys.redhat.com> (raw)
In-Reply-To: <20120925093715.GF9189@infradead.org>
On Tue, Sep 25, 2012 at 05:37:15AM -0400, Christoph Hellwig wrote:
> On Thu, Sep 20, 2012 at 10:32:39AM -0300, Carlos Maiolino wrote:
> > With the changes made on xfs_set_inode64(), to make it behave as
> > xfs_set_inode32() (now leaving to the caller the responsibility to update
> > mp->m_maxagi), we use the return value of xfs_set_inode64() to update
> > mp->m_maxagi during remount.
> >
> > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
>
> Shouldn;t this be part of the previous patch?
>
> Otherwise looks good.
>
dchinner suggested to keep small changes into different patches, once the
xfs_set_inode64() was added previously, adding a separate patche to add
xfs_set_inode32() and another one to change the behaviour of both functions
looks reasonable to me
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
--Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-25 13:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 13:32 [PATCH 0/6 V4] inode32/inode64 allocation changes Carlos Maiolino
2012-09-20 13:32 ` [PATCH 1/6] xfs: Fix m_agirotor reset during AG selection Carlos Maiolino
2012-09-25 9:34 ` Christoph Hellwig
2012-09-26 20:19 ` Mark Tinguely
2012-09-20 13:32 ` [PATCH 2/6] xfs: make inode64 as the default allocation mode Carlos Maiolino
2012-09-25 9:35 ` Christoph Hellwig
2012-09-26 20:20 ` Mark Tinguely
2012-09-20 13:32 ` [PATCH 3/6] xfs: reduce code duplication handling inode32/64 options Carlos Maiolino
2012-09-25 9:36 ` Christoph Hellwig
2012-09-26 20:20 ` Mark Tinguely
2012-09-20 13:32 ` [PATCH 4/6] xfs: Fix mp->m_maxagi update during inode64 remount Carlos Maiolino
2012-09-25 9:37 ` Christoph Hellwig
2012-09-25 13:33 ` Carlos Maiolino [this message]
2012-09-26 20:21 ` Mark Tinguely
2012-09-20 13:32 ` [PATCH 5/6] xfs: add inode64->inode32 transition into xfs_set_inode32() Carlos Maiolino
2012-09-25 9:37 ` Christoph Hellwig
2012-09-26 20:21 ` Mark Tinguely
2012-09-20 13:32 ` [PATCH 6/6] xfs: Make inode32 a remountable option Carlos Maiolino
2012-09-25 9:37 ` Christoph Hellwig
2012-09-26 20:21 ` Mark Tinguely
2012-09-20 13:51 ` [PATCH 0/6 V4] inode32/inode64 allocation changes Brian Foster
2012-09-21 21:22 ` Ben Myers
2012-09-21 21:34 ` Ben Myers
2012-09-26 21:23 ` Ben Myers
-- strict thread matches above, loose matches on Subject: below --
2012-09-19 6:10 [PATCH 0/6 V3] " Carlos Maiolino
2012-09-19 6:11 ` [PATCH 4/6] xfs: Fix mp->m_maxagi update during inode64 remount Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925133329.GA10780@andromeda.usersys.redhat.com \
--to=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox