From: Ben Myers <bpm@sgi.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3 v2] xfs: zero allocation_args on the kernel stack
Date: Tue, 25 Sep 2012 15:20:54 -0500 [thread overview]
Message-ID: <20120925202054.GA13214@sgi.com> (raw)
In-Reply-To: <20120920181650.041917183@sgi.com>
On Thu, Sep 20, 2012 at 01:16:45PM -0500, Mark Tinguely wrote:
> Zero the kernel stack space that makes up the xfs_alloc_arg structures.
>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
I'll just double check that you got all usages of xfs_alloc_arg_t:
xfs_inobt_alloc_block... fixed in f5eb8e7c by HCH
xfs_ialloc_ag_alloc... fixed below
xfs_bmbt_alloc_block... also fixed in f5eb8e7c
xfs_bmap_local_to_extents... fixed below
xfs_bmap_extents_to_btree... fixed below
xfs_bmap_btalloc... fixed below
xfs_free_extent... fixed in 0e1edbd9 by Nathan Scott
xfs_alloc_fix_freelist... fixed below
Looks good!
Reviewed-by: Ben Myers <bpm@sgi.com>
>
> ---
> fs/xfs/xfs_alloc.c | 1 +
> fs/xfs/xfs_bmap.c | 3 +++
> fs/xfs/xfs_ialloc.c | 1 +
> 3 files changed, 5 insertions(+)
>
> Index: b/fs/xfs/xfs_alloc.c
> ===================================================================
> --- a/fs/xfs/xfs_alloc.c
> +++ b/fs/xfs/xfs_alloc.c
> @@ -1866,6 +1866,7 @@ xfs_alloc_fix_freelist(
> /*
> * Initialize the args structure.
> */
> + memset(&targs, 0, sizeof(targs));
> targs.tp = tp;
> targs.mp = mp;
> targs.agbp = agbp;
> Index: b/fs/xfs/xfs_bmap.c
> ===================================================================
> --- a/fs/xfs/xfs_bmap.c
> +++ b/fs/xfs/xfs_bmap.c
> @@ -2437,6 +2437,7 @@ xfs_bmap_btalloc(
> * Normal allocation, done through xfs_alloc_vextent.
> */
> tryagain = isaligned = 0;
> + memset(&args, 0, sizeof(args));
> args.tp = ap->tp;
> args.mp = mp;
> args.fsbno = ap->blkno;
> @@ -3082,6 +3083,7 @@ xfs_bmap_extents_to_btree(
> * Convert to a btree with two levels, one record in root.
> */
> XFS_IFORK_FMT_SET(ip, whichfork, XFS_DINODE_FMT_BTREE);
> + memset(&args, 0, sizeof(args));
> args.tp = tp;
> args.mp = mp;
> args.firstblock = *firstblock;
> @@ -3237,6 +3239,7 @@ xfs_bmap_local_to_extents(
> xfs_buf_t *bp; /* buffer for extent block */
> xfs_bmbt_rec_host_t *ep;/* extent record pointer */
>
> + memset(&args, 0, sizeof(args));
> args.tp = tp;
> args.mp = ip->i_mount;
> args.firstblock = *firstblock;
> Index: b/fs/xfs/xfs_ialloc.c
> ===================================================================
> --- a/fs/xfs/xfs_ialloc.c
> +++ b/fs/xfs/xfs_ialloc.c
> @@ -250,6 +250,7 @@ xfs_ialloc_ag_alloc(
> /* boundary */
> struct xfs_perag *pag;
>
> + memset(&args, 0, sizeof(args));
> args.tp = tp;
> args.mp = tp->t_mountp;
>
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-25 20:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 16:31 [PATCH 0/3] xfs: allocation worker causes freelist buffer lock hang tinguely
2012-09-19 16:31 ` [PATCH 1/3] xfs: restrict allocate worker to x86_64 tinguely
2012-09-19 21:54 ` Dave Chinner
2012-09-20 17:37 ` Mark Tinguely
2012-09-24 17:37 ` Ben Myers
2012-09-25 0:14 ` Dave Chinner
2012-09-19 16:31 ` [PATCH 2/3] xfs: move allocate worker tinguely
2012-09-19 16:31 ` [PATCH 3/3] xfs: zero allocation_args on the kernel stack tinguely
2012-09-19 23:41 ` Dave Chinner
2012-09-20 18:16 ` [PATCH 3/3 v2] " Mark Tinguely
2012-09-25 20:20 ` Ben Myers [this message]
2012-10-18 22:52 ` Ben Myers
2012-09-19 23:34 ` [PATCH 0/3] xfs: allocation worker causes freelist buffer lock hang Dave Chinner
2012-09-20 13:49 ` Mark Tinguely
2012-09-24 13:25 ` Dave Chinner
2012-09-24 17:11 ` Ben Myers
2012-09-24 18:09 ` Mark Tinguely
2012-09-25 0:56 ` Dave Chinner
2012-09-25 15:14 ` Mark Tinguely
2012-09-25 22:01 ` Dave Chinner
2012-09-26 14:14 ` Mark Tinguely
2012-09-26 23:41 ` Dave Chinner
2012-09-27 20:10 ` Mark Tinguely
2012-09-28 3:08 ` Dave Chinner
2012-10-01 22:10 ` [PATCH 0/3] xfs: allocation worker causes freelist buffer lock Mark Tinguely
2012-10-01 23:10 ` Dave Chinner
2012-09-27 22:48 ` [PATCH 0/3] xfs: allocation worker causes freelist buffer lock hang Ben Myers
2012-09-27 23:17 ` Mark Tinguely
2012-09-27 23:27 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925202054.GA13214@sgi.com \
--to=bpm@sgi.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox