From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q8R05LwX012226 for ; Wed, 26 Sep 2012 19:05:21 -0500 Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id aqMXcDUiSGtSpHBy for ; Wed, 26 Sep 2012 17:06:39 -0700 (PDT) Date: Thu, 27 Sep 2012 10:06:38 +1000 From: Dave Chinner Subject: Re: [PATCH 2/6] xfstest: add configurable load factors Message-ID: <20120927000638.GC15236@dastard> References: <1348496601-32637-1-git-send-email-dmonakhov@openvz.org> <1348496601-32637-2-git-send-email-dmonakhov@openvz.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1348496601-32637-2-git-send-email-dmonakhov@openvz.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dmitry Monakhov Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, hch@lst.de, xfs@oss.sgi.com On Mon, Sep 24, 2012 at 06:23:17PM +0400, Dmitry Monakhov wrote: > Most stress test has probable behaviour, the longer test run the > larger corner cases will be cover. It is reasonable to allow > user to provide some sort of system load factor. > This patch introduce two global variables > LOAD_FACTOR: Usually means factor number of running tasks > TIME_FACTOR: Usually means factor of run time, or number of operations > If not speficied both variables defined to 1, so original behaviour > preserved. > > TODO: Change all stress tests to use this variables > > Signed-off-by: Dmitry Monakhov > --- > common.config | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/common.config b/common.config > index d5c8956..cfa7bde 100644 > --- a/common.config > +++ b/common.config > @@ -253,5 +253,13 @@ if [ ! -z "$SCRATCH_MNT" -a ! -d "$SCRATCH_MNT" ]; then > exit 1 > fi > > +if [ -z "$LOAD_FACTOR" ]; then > + LOAD_FACTOR=1 > +fi > + > +if [ -z "$TIME_FACTOR" ]; then > + TIME_FACTOR=1 > +fi They probably need to be exparted variables set up through the check script, not somthing sourced via common.config. i.e. something like this in check where the environment is being set up: export TIME_FACTOR=${TIME_FACTOR:=1} export LOAD_FACTOR=${LOAD_FACTOR:=1} Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs