Re: [PATCH v4 4/8] xfs: export xfs_free_eofblocks() and return EAGAIN on trylock failure

Dave Chinner
2012-09-28T06:59:34Z

On Thu, Sep 27, 2012 at 01:45:48PM -0400, Brian Foster wrote:
> Turn xfs_free_eofblocks() into a non-static function, return EAGAIN to
> indicate trylock failure and make sure this error is not propagated in
> xfs_release().

You might want to change the title of the patch - "export" when
talking about functions in kernel code has specific meaning i.e.
EXPORT_SYMBOL() and that's different to making something
non-static...

Otherwise looks ok.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com