From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: only update the last_sync_lsn when a transaction completes
Date: Sun, 30 Sep 2012 12:22:35 +1000 [thread overview]
Message-ID: <20120930022235.GG23520@dastard> (raw)
In-Reply-To: <20120928233752.GE23520@dastard>
On Sat, Sep 29, 2012 at 09:37:52AM +1000, Dave Chinner wrote:
> On Fri, Sep 28, 2012 at 08:40:38AM -0400, Christoph Hellwig wrote:
> >
> > Looks good.
> >
> > Do you have any testcase for this? It doesn't look like an issue found
> > by code inspection.
>
> Yeah, test 182 with my xfssyncd-die-die-die patchset triggers it
> 100% reliably.
FWIW, I've occasionally seen unreproducable recovery issues that
could have been caused by this for many years now. This is
effectively correcting a zero-day bug in the log behaviour. Here's
the commit that introduced this behaviour:
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=archive/xfs-import.git;a=commitdiff;h=99b58644923246c710c6dc9f7b47bcae66ed3c63
Dated 4th May, 1994.
It's definitely a contender for the oldest bug we've ever found in
the XFS code base...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-30 2:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 4:37 [PATCH] xfs: only update the last_sync_lsn when a transaction completes Dave Chinner
2012-09-28 12:40 ` Christoph Hellwig
2012-09-28 23:37 ` Dave Chinner
2012-09-30 2:22 ` Dave Chinner [this message]
2012-09-28 17:46 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120930022235.GG23520@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox