From: Dave Chinner <david@fromorbit.com>
To: Linda Walsh <xfs@tlinx.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+attachment)
Date: Wed, 3 Oct 2012 09:14:00 +1000 [thread overview]
Message-ID: <20121002231359.GV23520@dastard> (raw)
In-Reply-To: <506B7018.7040000@tlinx.org>
On Tue, Oct 02, 2012 at 03:52:08PM -0700, Linda Walsh wrote:
> Dave Chinner wrote:
> >Patches welcome.
> >
> >Cheers,
> >
> >Dave.
> ---
> Gee, that's a hard one... (build and tested that it was included)...
Actually, it's a lot more than just changing the default. If the
build system doesn't have libreadline/libedit/libtermcap installed,
the build will fail.
You need to add detection of the libraries' presence on the build
system, and then the "--enable-*" options can go away entirely.
See, for example, the way libuuid is detected in
m4/package_uuiddev.m4....
Also, libedit is only supposed to be used as a fallback option if
libreadline is not available.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-02 23:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 16:44 Why xfs_<utils> not 'readline' w/line-edit & history enabled? Linda Walsh
2012-10-02 18:41 ` Kinzel, David
2012-10-02 20:17 ` Dave Chinner
2012-10-02 21:29 ` Linda Walsh
2012-10-03 2:06 ` Eric Sandeen
2012-10-03 2:16 ` Nathan Scott
2012-10-03 3:51 ` Linda Walsh
2012-10-03 3:58 ` Nathan Scott
2012-10-03 4:21 ` Linda Walsh
2012-10-04 12:12 ` David Disseldorp
2012-10-02 21:30 ` Linda Walsh
2012-10-02 21:34 ` Linda Walsh
2012-10-02 21:52 ` Dave Chinner
2012-10-02 22:52 ` Why xfs_<utils> not 'readline' w/line-edit & history enabled? (+attachment) Linda Walsh
2012-10-02 23:14 ` Dave Chinner [this message]
2012-10-02 23:34 ` Linda Walsh
2012-10-02 23:50 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002231359.GV23520@dastard \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
--cc=xfs@tlinx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox