Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work

Christoph Hellwig
2012-10-05T18:15:19Z

On Fri, Oct 05, 2012 at 12:18:57PM -0500, Ben Myers wrote:
> ASSERT(mp->m_flags & XFS_MOUNT_RDONLY);
> }
>
> + xfs_log_work_queue(mp);
> +
> return error;

I still think queueing the work item here if we return a failure is
the wrong thing to do.