Re: [patch v4 04/13] [PATCH 04/13] xfs: sync work is now only periodic log work

Mark Tinguely
2012-10-05T18:30:19Z

On 10/05/12 13:16, Christoph Hellwig wrote:
> On Fri, Oct 05, 2012 at 12:18:57PM -0500, Ben Myers wrote:
>> ASSERT(mp->m_flags& XFS_MOUNT_RDONLY);
>> }
>>
>> + xfs_log_work_queue(mp);
>> +
>> return error;
>
> I still think queueing the work item here if we return a failure is
> the wrong thing to do.
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

You are correct. I did not see that it was not moved when mentioned in
the first series.

--Mark.