From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q99JRSrh092018 for ; Tue, 9 Oct 2012 14:27:28 -0500 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 0QmZ5G73QVm3EM3j for ; Tue, 09 Oct 2012 12:28:58 -0700 (PDT) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q99JSwUx024771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Oct 2012 15:28:58 -0400 Received: from andromeda.usersys.redhat.com (ovpn-113-88.phx2.redhat.com [10.3.113.88]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q99JSte2013254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Tue, 9 Oct 2012 15:28:57 -0400 Date: Tue, 9 Oct 2012 16:28:54 -0300 From: Carlos Maiolino Subject: Re: [PATCH] xfs: report projid32bit feature in geometry call Message-ID: <20121009192854.GA5312@andromeda.usersys.redhat.com> References: <507476F1.3080503@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <507476F1.3080503@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com On Tue, Oct 09, 2012 at 02:11:45PM -0500, Eric Sandeen wrote: > When xfs gained the projid32bit feature, it was never added to > the FSGEOMETRY ioctl feature flags, so it's not queryable without > this patch. > > Signed-off-by: Eric Sandeen > --- > > note1: is there a reason we had gaps in the flags? > note2: I don't *think* this requires a new version for the ioctl > > diff --git a/fs/xfs/xfs_fs.h b/fs/xfs/xfs_fs.h > index c13fed8..0948c04 100644 > --- a/fs/xfs/xfs_fs.h > +++ b/fs/xfs/xfs_fs.h > @@ -233,7 +233,8 @@ typedef struct xfs_fsop_resblks { > #define XFS_FSOP_GEOM_FLAGS_LOGV2 0x0100 /* log format version 2 */ > #define XFS_FSOP_GEOM_FLAGS_SECTOR 0x0200 /* sector sizes >1BB */ > #define XFS_FSOP_GEOM_FLAGS_ATTR2 0x0400 /* inline attributes rework */ > -#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */ > +#define XFS_FSOP_GEOM_FLAGS_PROJID32 0x0800 /* 32-bit project IDs */ > +#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */ > #define XFS_FSOP_GEOM_FLAGS_LAZYSB 0x4000 /* lazy superblock counters */ > > > diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c > index c25b094..89ad847 100644 > --- a/fs/xfs/xfs_fsops.c > +++ b/fs/xfs/xfs_fsops.c > @@ -97,7 +97,9 @@ xfs_fs_geometry( > (xfs_sb_version_haslazysbcount(&mp->m_sb) ? > XFS_FSOP_GEOM_FLAGS_LAZYSB : 0) | > (xfs_sb_version_hasattr2(&mp->m_sb) ? > - XFS_FSOP_GEOM_FLAGS_ATTR2 : 0); > + XFS_FSOP_GEOM_FLAGS_ATTR2 : 0) | > + (xfs_sb_version_hasprojid32bit(&mp->m_sb) ? > + XFS_FSOP_GEOM_FLAGS_PROJID32 : 0); > geo->logsectsize = xfs_sb_version_hassector(&mp->m_sb) ? > mp->m_sb.sb_logsectsize : BBSIZE; > geo->rtsectsize = mp->m_sb.sb_blocksize; > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs Looks good, Reviewed-by: Carlos Maiolino -- --Carlos _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs