From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q99MQs5h116402 for ; Tue, 9 Oct 2012 17:26:54 -0500 Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id sGyXovscvyveLYVd for ; Tue, 09 Oct 2012 15:28:23 -0700 (PDT) Date: Wed, 10 Oct 2012 09:28:06 +1100 From: Dave Chinner Subject: Re: [PATCH 2/2] xfs_io: configure tests for preadv/pwritev & sync_file_range Message-ID: <20121009222806.GS23644@dastard> References: <50749EE2.6070408@redhat.com> <5074A05A.6000709@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5074A05A.6000709@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs-oss On Tue, Oct 09, 2012 at 05:08:26PM -0500, Eric Sandeen wrote: > On older systems we may not have preadv/pwritev and/or > sync_file_range. > > Add the configure magic, and stub out the code > where needed. > > (sync_file_range just needed a better test; preadv/pwritev > took a little more rearranging) > > And fix a couple typos ("numberic") while we're at it. > > Signed-off-by: Eric Sandeen Looks fine, though the "HAVE_PREADV" in the pwritev case is a bit wierd. Perhaps doing this: > diff --git a/include/builddefs.in b/include/builddefs.in > index 81ebfcd..4a0e910 100644 > --- a/include/builddefs.in > +++ b/include/builddefs.in > @@ -101,6 +101,8 @@ HAVE_GETMNTENT = @have_getmntent@ > HAVE_GETMNTINFO = @have_getmntinfo@ > HAVE_FALLOCATE = @have_fallocate@ > HAVE_FIEMAP = @have_fiemap@ > +HAVE_PREADV = @have_preadv@ HAVE_PWRITEV = @have_preadv@ Would reduce that wierdness a bit when looking at the pwritev code.... Otherwise everything else looks ok. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs