From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2 V2] xfs_io: configure tests for preadv/pwritev & sync_file_range
Date: Thu, 11 Oct 2012 10:25:53 +1100 [thread overview]
Message-ID: <20121010232553.GB23644@dastard> (raw)
In-Reply-To: <5074EE1B.3090600@sandeen.net>
On Tue, Oct 09, 2012 at 10:40:11PM -0500, Eric Sandeen wrote:
> On older systems we may not have preadv/pwritev and/or
> sync_file_range.
>
> Add the configure magic, and stub out the code
> where needed.
>
> (sync_file_range just needed a better test; preadv/pwritev
> took a little more rearranging)
>
> And fix a couple typos ("numberic") while we're at it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> V2: add -DHAVE_PWRITEV and use that test in io/pwrite.c
> rather than HAVE_PREADV
.....
> +# Also implies PWRITEV
> +ifeq ($(HAVE_PREADV),yes)
> +LCFLAGS += -DHAVE_PREADV -DHAVE_PWRITEV
> +endif
Nice solution ;)
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-10 23:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 22:02 [PATCH 1/2] xfs_io: include headers for preadv/pwritev Eric Sandeen
2012-10-09 22:08 ` [PATCH 2/2] xfs_io: configure tests for preadv/pwritev & sync_file_range Eric Sandeen
2012-10-09 22:28 ` Dave Chinner
2012-10-09 22:32 ` Eric Sandeen
2012-10-09 22:56 ` Dave Chinner
2012-10-09 22:57 ` Eric Sandeen
2012-10-09 23:05 ` Dave Chinner
2012-10-10 3:40 ` [PATCH 2/2 V2] " Eric Sandeen
2012-10-10 23:25 ` Dave Chinner [this message]
2012-10-09 22:21 ` [PATCH 1/2] xfs_io: include headers for preadv/pwritev Dave Chinner
2012-10-10 3:37 ` [PATCH 1/2 V2] " Eric Sandeen
2012-10-10 23:24 ` Dave Chinner
2012-10-11 20:40 ` [PATCH 1/2] " Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010232553.GB23644@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox