From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q9BLgobp243947 for ; Thu, 11 Oct 2012 16:42:50 -0500 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id wYQ7mBKNVuenRsp3 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 11 Oct 2012 14:44:22 -0700 (PDT) Date: Thu, 11 Oct 2012 17:44:21 -0400 From: Christoph Hellwig Subject: Re: [PATCH 07/19] xfs: verify AGFL blocks as they are read from disk Message-ID: <20121011214421.GG6346@infradead.org> References: <1349754670-32009-1-git-send-email-david@fromorbit.com> <1349754670-32009-8-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1349754670-32009-8-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Tue, Oct 09, 2012 at 02:50:58PM +1100, Dave Chinner wrote: > From: Dave Chinner > > Add an AGFL block verify callback function and pass it into the > buffer read functions. Add a debug only check for valid block > numbers in the AGFL. The check isn't executed only for debug builds, but rather all the time. I'm not sure that this actually is a good idea. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs