From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>,
Dave Chinner <dchinner@redhat.com>,
nscott@redhat.com
Subject: Re: [PATCH] xfs_quota: XFS_XFLAG_PROJINHERIT is only for dirs
Date: Sun, 14 Oct 2012 10:34:31 +1100 [thread overview]
Message-ID: <20121013233431.GQ2739@dastard> (raw)
In-Reply-To: <20121013155205.GA11037@infradead.org>
On Sat, Oct 13, 2012 at 11:52:05AM -0400, Christoph Hellwig wrote:
> On Fri, Oct 12, 2012 at 11:19:55AM -0500, Eric Sandeen wrote:
> > xfs_quota has long set XFS_XFLAG_PROJINHERIT on all files,
> > and tested for presence on all files. However, Dave's semi-recent
> > xfs_repair update is now flagging this as an error:
>
> I think we should rever that part of the repair patch. While there
> really is not point to have XFS_XFLAG_PROJINHERIT set on non-directory
> files we have been setting it for year, so repair should cope with that.
Repair does cope with it - it issues a warning and clears the flag.
It doesn't stop, it simply fixes an inconsistency in the inode flags.
The main problem, by the sounds of it, is that repair issues a
warning that it is clearing the flags that should not be set. This
is what makes check_scratch_fs fail because of the extra output.
That's easy to fix - filter the line from the repair output and be
done with it. In future (with Eric's patch) this situation won't
occur.
So, really, I think the only thing that needs modifying to handle
this situation is a filter update to xfstests...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-13 23:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 16:19 [PATCH] xfs_quota: XFS_XFLAG_PROJINHERIT is only for dirs Eric Sandeen
2012-10-13 15:52 ` Christoph Hellwig
2012-10-13 21:22 ` Eric Sandeen
2012-10-13 23:34 ` Dave Chinner [this message]
2012-10-14 0:05 ` Eric Sandeen
2012-10-14 0:14 ` Dave Chinner
2012-10-16 20:17 ` Ben Myers
2012-10-16 20:34 ` Dave Chinner
2012-10-17 15:54 ` Eric Sandeen
2012-10-23 12:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121013233431.GQ2739@dastard \
--to=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=nscott@redhat.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox