From: Ben Myers <bpm@sgi.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB
Date: Tue, 16 Oct 2012 15:48:25 -0500 [thread overview]
Message-ID: <20121016204825.GE1377@sgi.com> (raw)
In-Reply-To: <20121016201645.GJ2739@dastard>
Hey Lukas,
On Wed, Oct 17, 2012 at 07:16:45AM +1100, Dave Chinner wrote:
> On Tue, Oct 16, 2012 at 11:41:33AM +0200, Lukas Czerner wrote:
> > This tests corner case in FITRIM implementation where range size is
> > smaller than file system block or zero. In this case FITRIM should fail
> > with EINVAL.
> >
> > The problem was spotted in xfs and ext4 where in case of length = 0 the
> > 'end' variable underflowed. In case of length smaller than 1 FSB FITRIM
> > finished successfully, but we really should rather return EINVAL in both
> > cases.
> >
> > (This patch has to be applied after 'Use upstream version of fstrim
> > instead of the local one')
> >
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> > ---
> > 286 | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 286.out | 6 ++++++
>
> We've already got 286 (and 287), so this should probably be 288...
Unless you've got something else to fix, don't worry about reposting to update
the test number... We sometimes have collisions and it is just easiest if we
update it at commit time.
Thanks,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-16 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 9:41 [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB Lukas Czerner
2012-10-16 9:41 ` [PATCH 2/2] 251: Do not allow step to be zero Lukas Czerner
2012-10-16 20:18 ` Dave Chinner
2012-10-24 20:43 ` Rich Johnston
2012-10-16 20:16 ` [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB Dave Chinner
2012-10-16 20:48 ` Ben Myers [this message]
2012-10-24 20:39 ` Rich Johnston
2012-10-24 20:44 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016204825.GE1377@sgi.com \
--to=bpm@sgi.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox