From: Dave Chinner <david@fromorbit.com>
To: Jie Liu <jeff.liu@oracle.com>
Cc: Mark Tinguely <tinguely@sgi.com>, xfs@oss.sgi.com
Subject: Re: xfstests: SEEK_HOLE/SEEK_DATA advanced tests
Date: Wed, 17 Oct 2012 18:24:24 +1100 [thread overview]
Message-ID: <20121017072424.GC26797@dastard> (raw)
In-Reply-To: <507E284D.40800@oracle.com>
On Wed, Oct 17, 2012 at 11:38:53AM +0800, Jie Liu wrote:
> On 10/17/12 10:34, Dave Chinner wrote:
> > On Tue, Oct 16, 2012 at 03:42:41PM -0500, Mark Tinguely wrote:
> >> This is the test of the advanced SEEK_HOLE and SEEK_DATA features
> >> of the lseek() function call.
> >>
> >> Jie Liu <jeff.liu@oracle.com> wrote the C code, I converted it to
> >> a test with his permission.
> > Jie, can you sign-off on this patch as well as it has Oracle
> > copyright statements in it?
> Hi Dave,
>
> I can sign-off this patch, but it's better to keep the copyright
> statements with SGI for this test script since
> it wrote by Mark, and Mark is already made the C test file as Oracle.
The .c file has this:
+ * Copyright (C) 2011-2012 Oracle. All rights reserved.
Which is why the patch needs your signoff.
But if the test is redone without the .c file (i.e. SEEK_HOLE/DATA
added to xfs_io) then it won't be necessary (unless you do that
work :).
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-17 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121016204240.142425319@sgi.com>
2012-10-16 20:42 ` xfstests: SEEK_HOLE/SEEK_DATA advanced tests Mark Tinguely
2012-10-17 2:34 ` Dave Chinner
2012-10-17 3:38 ` Jie Liu
2012-10-17 7:24 ` Dave Chinner [this message]
2012-10-17 8:33 ` Jie Liu
2012-10-17 12:52 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121017072424.GC26797@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox