Re: [PATCH] mkfs: update manpage to match current inode allocation behaviour

[Carlos Maiolino <cmaiolino@redhat.com>]

On Thu, Oct 18, 2012 at 05:38:45PM -0500, Eric Sandeen wrote:
> On 10/18/12 10:42 AM, Carlos Maiolino wrote:
> > Once inode64 is the default allocator, mkfs man page needs to be updated to
> > match the current behaviour.
> > 
> > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> > ---
> >  man/man8/mkfs.xfs.8 | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
> > index fa52152..c33cfb2 100644
> > --- a/man/man8/mkfs.xfs.8
> > +++ b/man/man8/mkfs.xfs.8
> > @@ -309,16 +309,17 @@ can be allocated to inodes. The default
> >  is 25% for filesystems under 1TB, 5% for filesystems under 50TB and 1%
> >  for filesystems over 50TB.
> >  .IP
> > -In the default inode allocation mode, inode blocks are chosen such
> > +In the inode32 inode allocation mode, inode blocks are chosen such
> >  that inode numbers will not exceed 32 bits, which restricts the inode
> >  blocks to the lower portion of the filesystem. The data block
> >  allocator will avoid these low blocks to accommodate the specified
> >  maxpct, so a high value may result in a filesystem with nothing but
> >  inodes in a significant portion of the lower blocks of the filesystem.
> > -(This restriction is not present when the filesystem is mounted with
> > +(This restriction is not present in the default inode allocation mode,
> > +i.e. when the filesystem is mounted with
> >  the
> >  .I "inode64"
> > -option on 64-bit platforms).
> > +option).
> 
> This is a little confusing - the "default" mode when "mounted with the -o inode64 option?"
> 
> If you mount with -o anything that's not quite default - or at best restating defaults.
> 
> How about:
> 
> (This restriction is not present in the default inode allocation mode,
> i.e. when the filesystem is mounted without the
>  .I "inode32"
> option).
> 
Fair enough.

How about:

"i.e. using inode64" or "i.e. inode64 mode"

or even, rephasing everything:

"This restriction is not present in the default (inode64) inode allocation mode

I was thinking in something that would highlight inode64 as the default
allocation mode


> -Eric
> 
> >  .IP
> >  Setting the value to 0 means that essentially all of the filesystem
> >  can become inode blocks, subject to inode32 restrictions.
> > 
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
--Carlos

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs