From: Christoph Hellwig <hch@infradead.org>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Update inode alloc comments
Date: Tue, 23 Oct 2012 08:23:55 -0400 [thread overview]
Message-ID: <20121023122355.GB7341@infradead.org> (raw)
In-Reply-To: <1350742099-8397-1-git-send-email-cmaiolino@redhat.com>
On Sat, Oct 20, 2012 at 11:08:19AM -0300, Carlos Maiolino wrote:
> I found some out of date comments while studying the inode allocation code, so I
> believe it's worth to have these comments updated.
>
> It basically rewrites the comment regarding to "call_again" variable, which is
> not used anymore, but instead, callers of xfs_ialloc() decides if it needs to be
> called again relying only if ialloc_context is NULL or not.
>
> Also did some small changes in another comment that I thought to be pertinent
> to the current behaviour of these functions and some alignment on both comments.
>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-23 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 14:08 [PATCH] xfs: Update inode alloc comments Carlos Maiolino
2012-10-23 12:23 ` Christoph Hellwig [this message]
2012-11-02 22:12 ` Ben Myers
2012-11-08 17:45 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023122355.GB7341@infradead.org \
--to=hch@infradead.org \
--cc=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox