Re: [PATCH v3] xfs_io: [v3] add the lseek() SEEK_DATA/SEEK_HOLE support

Mark Tinguely
2012-10-26T13:29:29Z

On 10/25/12 17:29, Dave Chinner wrote:
> On Thu, Oct 25, 2012 at 09:14:44AM -0500, Mark Tinguely wrote:
>> Add the lseek SEEK_DATA/SEEK_HOLE support into xfs_io.
>> The result from the lseek() call will be printed to the output.
>> For example:
>>
>> xfs_io> lseek -h 609k
>> Type Offset
>> hole 630784
>>
>> v1 -> v2 Add "-a" and "-r" options.
>> Simplify the output.
>> v2 -> v3 Refactor for configure.in -> configure.ac change.
>> SEEK_DATA with -1 offset behaves badly on older Linux.
>> Display error message as "ERR<errno>".
> ....
>> +
>> +#include<linux/fs.h>
>
> I missed this first time around - why is this include necessary?

Take it out and you will find that it contains the
defines for SEEK_DATA/SEEK_HOLE.

--Mark.