From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 24/23] xfs: convert buffer verifiers to an ops structure.
Date: Wed, 24 Oct 2012 08:42:15 +1100 [thread overview]
Message-ID: <20121023214215.GP4291@dastard> (raw)
In-Reply-To: <20121023123646.GJ7341@infradead.org>
On Tue, Oct 23, 2012 at 08:36:47AM -0400, Christoph Hellwig wrote:
> On Thu, Oct 18, 2012 at 03:50:28PM +1100, Dave Chinner wrote:
> > Here's a patch that does this. It adds on top of the series, and
> > points out more changes needed to growfs to support CRC checking
> > properly.
>
> I like this a lot, and I'm fine with having this at the end of the
> series if it makes your life easier.
Ok, cool, I'll keep it this way for the moment, then. If, for some
reason, I decide I need to rework the series again, I'll reorder it
then, but for now I don't see that happening.
> > -xfs_agfl_write_verify(
> > +xfs_agfl_read_verify(
> > struct xfs_buf *bp)
> > {
> > xfs_agfl_verify(bp);
> > }
> >
> > static void
> > -xfs_agfl_read_verify(
> > +xfs_agfl_write_verify(
> > struct xfs_buf *bp)
> > {
> > xfs_agfl_verify(bp);
> > - bp->b_pre_io = xfs_agfl_write_verify;
> > - bp->b_iodone = NULL;
> > - xfs_buf_ioend(bp, 0);
> > }
>
> Any good reason to keep all these no-op wrappers?
I can remove them, but I'd just have to re-introduce them when CRC
checking is added. i.e. read will need to verify the CRC, write will
need to calculate it and inserting the value.
I don't mind either way at this point - I already had them so I kept
them in place, but it's relatively easy to remove them from this
patch and reapply them later (i.e. just add a temporary patch to the
series to remove them, copy it away, fold the temp patch into this
one so that this patch removes them, then later on reverse apply the
tmp patch to re-introduce the wrappers).
Either way, the read/write verifier functions will be there in the
end. ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-23 21:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 5:44 [PATCH 00/23] xfs: metadata verifiers V2 Dave Chinner
2012-10-12 5:44 ` [PATCH 01/23] xfs: growfs: don't read garbage for new secondary superblocks Dave Chinner
2012-10-12 5:44 ` [PATCH 02/23] xfs: invalidate allocbt blocks moved to the free list Dave Chinner
2012-10-12 5:44 ` [PATCH 03/23] xfs: make buffer read verication an IO completion function Dave Chinner
2012-10-12 5:44 ` [PATCH 04/23] xfs: uncached buffer reads need to return an error Dave Chinner
2012-10-12 5:44 ` [PATCH 05/23] xfs: verify superblocks as they are read from disk Dave Chinner
2012-10-12 5:44 ` [PATCH 06/23] xfs: verify AGF blocks " Dave Chinner
2012-10-12 5:44 ` [PATCH 07/23] xfs: verify AGI " Dave Chinner
2012-10-12 5:44 ` [PATCH 08/23] xfs: verify AGFL " Dave Chinner
2012-10-12 5:44 ` [PATCH 09/23] xfs: verify inode buffers " Dave Chinner
2012-10-12 5:44 ` [PATCH 10/23] xfs: verify btree blocks " Dave Chinner
2012-10-12 5:44 ` [PATCH 11/23] xfs: verify dquot " Dave Chinner
2012-10-12 5:44 ` [PATCH 12/23] xfs: add verifier callback to directorry read code Dave Chinner
2012-10-12 5:44 ` [PATCH 13/23] xfs: factor dir2 block read operations Dave Chinner
2012-10-12 5:44 ` [PATCH 14/23] xfs: verify dir2 block format buffers Dave Chinner
2012-10-12 5:44 ` [PATCH 15/23] xfs: factor dir2 free block reading Dave Chinner
2012-10-12 5:44 ` [PATCH 16/23] xfs: factor out dir2 data " Dave Chinner
2012-10-12 5:44 ` [PATCH 17/23] xfs: factor dir2 leaf read Dave Chinner
2012-10-12 5:44 ` [PATCH 18/23] xfs: factor and verify attr leaf reads Dave Chinner
2012-10-12 5:44 ` [PATCH 19/23] xfs: add xfs_da_node verification Dave Chinner
2012-10-12 5:44 ` [PATCH 20/23] xfs: Add verifiers to dir2 data readahead Dave Chinner
2012-10-12 5:44 ` [PATCH 21/23] xfs: add buffer pre-write callback Dave Chinner
2012-10-12 5:44 ` [PATCH 22/23] xfs: add pre-write metadata buffer verifier callbacks Dave Chinner
2012-10-13 16:02 ` Christoph Hellwig
2012-10-14 0:12 ` Dave Chinner
2012-10-18 4:50 ` [PATCH 24/23] xfs: convert buffer verifiers to an ops structure Dave Chinner
2012-10-23 12:36 ` Christoph Hellwig
2012-10-23 21:42 ` Dave Chinner [this message]
2012-10-12 5:44 ` [PATCH 23/23] xfs: connect up write verifiers to new buffers Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023214215.GP4291@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox