Re: [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list

Christoph Hellwig
2012-10-26T08:45:45Z

> index f1647ca..f7876c6 100644
> --- a/fs/xfs/xfs_alloc_btree.c
> +++ b/fs/xfs/xfs_alloc_btree.c
> @@ -121,6 +121,8 @@ xfs_allocbt_free_block(
> xfs_extent_busy_insert(cur->bc_tp, be32_to_cpu(agf->agf_seqno), bno, 1,
> XFS_EXTENT_BUSY_SKIP_DISCARD);
> xfs_trans_agbtree_delta(cur->bc_tp, -1);
> +
> + xfs_trans_binval(cur->bc_tp, bp);
> return 0;

I'd be almost tempted to move this into the caller, as the bmap and
ialloc btrees do it and I always wondered how the alloc btree got away
without it.

Otherwise looks ok,

Reviewed-by: Christoph Hellwig <hch@lst.de>