Re: [PATCH 08/25] xfs: verify AGFL blocks as they are read from disk

Phil White
2012-10-30T17:56:16Z

On Thu, Oct 25, 2012 at 05:33:57PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Add an AGFL block verify callback function and pass it into the
> buffer read functions.
>
> While this commit adds verification code to the AGFL, it cannot be
> used reliably until the CRC format change comes along as mkfs does
> not initialise the full AGFL. Hence it can be full of garbage at the
> first mount and will fail verification right now. CRC enabled
> filesystems won't have this problem, so leave the code that has
> already been written ifdef'd out until the proper time.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/xfs_alloc.c | 40 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 39 insertions(+), 1 deletion(-)

Okee doke by me.

Reviewed-by: Phil White <pwhite@sgi.com>