public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: raghu.prabhu13@gmail.com
Cc: bpm@sgi.com, elder@kernel.org,
	Raghavendra D Prabhu <rprabhu@wnohang.net>,
	xfs@oss.sgi.com
Subject: Re: [PATCH v3 2/3] xfs: Print error when xfs_ialloc_ag_select fails to find continuous free space.
Date: Mon, 29 Oct 2012 09:10:59 +1100	[thread overview]
Message-ID: <20121028221059.GC4353@dastard> (raw)
In-Reply-To: <9acdfb22ee7a1fbf777f866182d01009a3bea879.1348641483.git.rprabhu@wnohang.net>

On Wed, Sep 26, 2012 at 12:26:48PM +0530, raghu.prabhu13@gmail.com wrote:
> From: Raghavendra D Prabhu <rprabhu@wnohang.net>
> 
> When xfs_ialloc_ag_select fails to find any AG with continuous free blocks
> required for inode allocation, printk the error in ratelimited manner.
> 
> Signed-off-by: Raghavendra D Prabhu <rprabhu@wnohang.net>
> ---
>  fs/xfs/xfs_ialloc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c
> index 5aceb3f..e75a39d 100644
> --- a/fs/xfs/xfs_ialloc.c
> +++ b/fs/xfs/xfs_ialloc.c
> @@ -539,8 +539,11 @@ nextag:
>  		if (agno >= agcount)
>  			agno = 0;
>  		if (agno == pagno) {
> -			if (flags == 0)
> +			if (flags == 0) {
> +				xfs_err_ratelimited(mp,
> +					"Out of continuous free blocks for inode allocation");
>  				return NULLAGNUMBER;
> +			}

>From here:

http://oss.sgi.com/archives/xfs/2012-09/msg00138.html

I quote:

| http://oss.sgi.com/archives/xfs/2012-06/msg00041.html
| 
| <quote>
| Couple of things for all 3 patches. Firstly - 80 columns. We tend
| to keep the pformat string on a single line so it is easy to grep
| for like so:
| 
|				pr_err_once(mp,
|                 "Insufficient contiguous free space for inode allocation");
| </quote>
| 
| So, you need to change the error message to the one suggested, and
| follow 80-character width limits like the rest of the code.
| 
| Also, I think the error message is better at the caller site, not in
| the function itself. i.e. if we get a NULLAGNUMBER returned, the
| caller decided whether to emit an error message or not."

So, the message here needs to change to what is suggested above, and
the location of the message needs to change i.e. to the caller, not
within the function itself.

Review comments need to be addressed before you repost patches....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2012-10-28 22:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26  6:56 [PATCH v3 0/3] Print when ENOSPC due to lack of inodes raghu.prabhu13
     [not found] ` <cover.1348641483.git.rprabhu@wnohang.net>
2012-09-26  6:56   ` [PATCH v3 1/3] xfs: Add ratelimited printk for different alert levels raghu.prabhu13
2012-09-26  6:56     ` [v3 Repost] " Raghavendra D Prabhu
2012-10-26 13:15     ` [v3,1/3] " Rich Johnston
2012-10-28 22:05     ` [PATCH v3 1/3] " Dave Chinner
2013-03-27 14:26     ` [v3 Repost] " Rich Johnston
2013-04-05 18:32       ` Ben Myers
2012-09-26  6:56   ` [PATCH v3 2/3] xfs: Print error when xfs_ialloc_ag_select fails to find continuous free space raghu.prabhu13
2012-10-26 13:15     ` [v3, " Rich Johnston
2012-10-28 22:10     ` Dave Chinner [this message]
2012-09-26  6:56   ` [PATCH v3 3/3] xfs: Print error when unable to allocate inodes or out of free inodes raghu.prabhu13
2012-10-26 13:15     ` [v3, " Rich Johnston
2012-10-28 23:21     ` [PATCH v3 " Dave Chinner
2012-10-24 20:56 ` [PATCH v3 0/3] Print when ENOSPC due to lack of inodes Raghavendra Prabhu
2012-10-25 15:23   ` Rich Johnston
2012-10-26 13:18   ` Rich Johnston
2012-10-28 22:05     ` Dave Chinner
2012-10-30 14:59       ` Ben Myers
2012-11-28  2:52   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121028221059.GC4353@dastard \
    --to=david@fromorbit.com \
    --cc=bpm@sgi.com \
    --cc=elder@kernel.org \
    --cc=raghu.prabhu13@gmail.com \
    --cc=rprabhu@wnohang.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox