From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cthulhu.engr.sgi.com (cthulhu.engr.sgi.com [150.166.39.100]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q9UHu6We061164 for ; Tue, 30 Oct 2012 12:56:23 -0500 Date: Mon, 29 Oct 2012 17:17:50 -0700 From: Phil White Subject: Re: [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks Message-ID: <20121030001750.GC30227@caliban.engr.sgi.com> References: <1351146854-19343-1-git-send-email-david@fromorbit.com> <1351146854-19343-2-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1351146854-19343-2-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Thu, Oct 25, 2012 at 05:33:50PM +1100, Dave Chinner wrote: > From: Dave Chinner > > When updating new secondary superblocks in a growfs operation, the > sueprblock buffer is read from the newly grown region of the > underlying device. This is not guaranteed to be zero, so violates > the underlying assumption that the unused parts of superblocks are > zero filled. Get a new buffer for these secondary superblocks to > ensure that the unused regions are zero filled correctly. > > Signed-off-by: Dave Chinner > Reviewed-by: Christoph Hellwig > --- > [ snip ] Looks good to me too. Reviewed-by: Phil White _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs