From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cthulhu.engr.sgi.com (cthulhu.engr.sgi.com [150.166.39.100]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q9UHu6Wc061164 for ; Tue, 30 Oct 2012 12:56:22 -0500 Date: Mon, 29 Oct 2012 17:55:36 -0700 From: Phil White Subject: Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function Message-ID: <20121030005535.GJ30227@caliban.engr.sgi.com> References: <1351146854-19343-1-git-send-email-david@fromorbit.com> <1351146854-19343-4-git-send-email-david@fromorbit.com> <20121030002916.GE30227@caliban.engr.sgi.com> <20121030004546.GW29378@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20121030004546.GW29378@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com, Phil White On Tue, Oct 30, 2012 at 11:45:46AM +1100, Dave Chinner wrote: > > This is OK with me so far, but I have comments on some of the callbacks. > > /me looks around, doesn't find anything... > > The comments must be elsewhere. ;) You surmised correctly. > BTW, Phil, can you trim away all the bits of the patch you aren't > commenting on? Having to scroll through hundreds of lines of quoted > email to find your replies is a little slow, and it's quite easy to > miss comments when they are widely spread apart. Most people just > quote the patch hunk they are making the comment about to avoid this > problem.... Will do. Sorry about that! -Phil _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs