From: Phil White <pwhite@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 24/25] xfs: convert buffer verifiers to an ops structure.
Date: Tue, 30 Oct 2012 06:41:19 -0700 [thread overview]
Message-ID: <20121030134118.GJ18595@caliban.engr.sgi.com> (raw)
In-Reply-To: <1351146854-19343-25-git-send-email-david@fromorbit.com>
On Thu, Oct 25, 2012 at 05:34:13PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> To separate the verifiers from iodone functions and associate read
> and write verifiers at the same time, introduce a buffer verifier
> operations structure to the xfs_buf.
>
> This avoids the need for assigning the write verifier, clearing the
> iodone function and re-running ioend processing in the read
> verifier, and gets rid of the nasty "b_pre_io" name for the write
> verifier function pointer. If we ever need to, it will also be
> easier to add further content specific callbacks to a buffer with an
> ops structure in place.
>
> We also avoid needing to export verifier functions, instead we
> can simply export the ops structures for those that are needed
> outside the function they are defined in.
>
> This patch also fixes a directory block readahead verifier issue
> it exposed.
>
> This patch also adds ops callbacks to the inode/alloc btree blocks
> initialised by growfs. These will need more work before they will
> work with CRCs.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/xfs_ag.h | 4 +++
> fs/xfs/xfs_alloc.c | 26 +++++++++++--------
> fs/xfs/xfs_alloc.h | 2 +-
> fs/xfs/xfs_alloc_btree.c | 18 +++++++------
> fs/xfs/xfs_alloc_btree.h | 2 ++
> fs/xfs/xfs_attr_leaf.c | 19 +++++++-------
> fs/xfs/xfs_attr_leaf.h | 3 ++-
> fs/xfs/xfs_bmap.c | 22 ++++++++--------
> fs/xfs/xfs_bmap_btree.c | 20 +++++++-------
> fs/xfs/xfs_bmap_btree.h | 3 +--
> fs/xfs/xfs_btree.c | 26 +++++++++----------
> fs/xfs/xfs_btree.h | 9 +++----
> fs/xfs/xfs_buf.c | 63 ++++++++++++++++++++++++++-------------------
> fs/xfs/xfs_buf.h | 24 ++++++++++-------
> fs/xfs/xfs_da_btree.c | 28 ++++++++++----------
> fs/xfs/xfs_da_btree.h | 4 +--
> fs/xfs/xfs_dir2_block.c | 20 +++++++-------
> fs/xfs/xfs_dir2_data.c | 52 ++++++++++++++++++++++++++++++-------
> fs/xfs/xfs_dir2_leaf.c | 36 ++++++++++++++------------
> fs/xfs/xfs_dir2_node.c | 26 ++++++++++---------
> fs/xfs/xfs_dir2_priv.h | 10 ++++---
> fs/xfs/xfs_dquot.c | 16 +++++++-----
> fs/xfs/xfs_fsops.c | 26 ++++++++++++++++---
> fs/xfs/xfs_ialloc.c | 18 +++++++------
> fs/xfs/xfs_ialloc.h | 2 +-
> fs/xfs/xfs_ialloc_btree.c | 17 ++++++------
> fs/xfs/xfs_ialloc_btree.h | 2 ++
> fs/xfs/xfs_inode.c | 22 +++++++++-------
> fs/xfs/xfs_inode.h | 3 +--
> fs/xfs/xfs_itable.c | 2 +-
> fs/xfs/xfs_log_recover.c | 2 +-
> fs/xfs/xfs_mount.c | 35 +++++++++++++++----------
> fs/xfs/xfs_mount.h | 4 +--
> fs/xfs/xfs_trans.h | 6 ++---
> fs/xfs/xfs_trans_buf.c | 8 +++---
> 35 files changed, 346 insertions(+), 234 deletions(-)
More mechanical changes. Looks good.
Reviewed-by: Phil White <pwhite@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-30 17:56 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 6:33 [PATCH 00/25, V3] xfs: metadata buffer verifiers Dave Chinner
2012-10-25 6:33 ` [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks Dave Chinner
2012-10-30 0:17 ` Phil White
2012-10-25 6:33 ` [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list Dave Chinner
2012-10-26 8:47 ` Christoph Hellwig
2012-10-30 0:22 ` Phil White
2012-10-25 6:33 ` [PATCH 03/25] xfs: make buffer read verication an IO completion function Dave Chinner
2012-10-30 0:29 ` Phil White
2012-10-30 0:45 ` Dave Chinner
2012-10-30 0:55 ` Phil White
2012-10-25 6:33 ` [PATCH 04/25] xfs: uncached buffer reads need to return an error Dave Chinner
2012-10-26 8:48 ` Christoph Hellwig
2012-10-30 0:36 ` Phil White
2012-10-25 6:33 ` [PATCH 05/25] xfs: verify superblocks as they are read from disk Dave Chinner
2012-10-30 0:48 ` Phil White
2012-10-25 6:33 ` [PATCH 06/25] xfs: verify AGF blocks " Dave Chinner
2012-10-30 0:51 ` Phil White
2012-10-25 6:33 ` [PATCH 07/25] xfs: verify AGI " Dave Chinner
2012-10-30 0:53 ` Phil White
2012-10-30 22:13 ` Dave Chinner
2012-10-25 6:33 ` [PATCH 08/25] xfs: verify AGFL " Dave Chinner
2012-10-30 1:00 ` Phil White
2012-10-25 6:33 ` [PATCH 09/25] xfs: verify inode buffers " Dave Chinner
2012-10-30 1:06 ` Phil White
2012-10-25 6:33 ` [PATCH 10/25] xfs: verify btree blocks " Dave Chinner
2012-10-30 1:14 ` Phil White
2012-10-25 6:34 ` [PATCH 11/25] xfs: verify dquot " Dave Chinner
2012-10-30 1:36 ` Phil White
2012-10-25 6:34 ` [PATCH 12/25] xfs: add verifier callback to directory read code Dave Chinner
2012-10-30 3:15 ` Phil White
2012-10-25 6:34 ` [PATCH 13/25] xfs: factor dir2 block read operations Dave Chinner
2012-10-30 3:23 ` Phil White
2012-10-30 22:16 ` Dave Chinner
2012-10-25 6:34 ` [PATCH 14/25] xfs: verify dir2 block format buffers Dave Chinner
2012-10-30 3:26 ` Phil White
2012-10-25 6:34 ` [PATCH 15/25] xfs: factor dir2 free block reading Dave Chinner
2012-10-30 13:14 ` Phil White
2012-10-25 6:34 ` [PATCH 16/25] xfs: factor out dir2 data " Dave Chinner
2012-10-30 13:21 ` Phil White
2012-10-25 6:34 ` [PATCH 17/25] xfs: factor dir2 leaf read Dave Chinner
2012-10-30 13:22 ` Phil White
2012-10-25 6:34 ` [PATCH 18/25] xfs: factor and verify attr leaf reads Dave Chinner
2012-10-30 13:26 ` Phil White
2012-10-25 6:34 ` [PATCH 19/25] xfs: add xfs_da_node verification Dave Chinner
2012-10-30 13:30 ` Phil White
2012-10-30 22:23 ` Dave Chinner
2012-10-31 0:23 ` Phil White
2012-10-31 0:50 ` Dave Chinner
2012-10-25 6:34 ` [PATCH 20/25] xfs: Add verifiers to dir2 data readahead Dave Chinner
2012-10-30 13:31 ` Phil White
2012-10-25 6:34 ` [PATCH 21/25] xfs: add buffer pre-write callback Dave Chinner
2012-10-26 8:50 ` Christoph Hellwig
2012-10-30 22:30 ` Dave Chinner
2012-10-31 10:20 ` Christoph Hellwig
2012-10-30 13:32 ` Phil White
2012-10-25 6:34 ` [PATCH 22/25] xfs: add pre-write metadata buffer verifier callbacks Dave Chinner
2012-10-30 13:34 ` Phil White
2012-10-25 6:34 ` [PATCH 23/25] xfs: connect up write verifiers to new buffers Dave Chinner
2012-10-30 13:39 ` Phil White
2012-10-30 22:34 ` Dave Chinner
2012-10-25 6:34 ` [PATCH 24/25] xfs: convert buffer verifiers to an ops structure Dave Chinner
2012-10-30 13:41 ` Phil White [this message]
2012-10-25 6:34 ` [PATCH 25/25] xfs: add write verifiers to log recovery Dave Chinner
2012-10-26 8:54 ` Christoph Hellwig
2012-10-26 20:31 ` Dave Chinner
2012-10-30 12:23 ` Christoph Hellwig
2012-10-30 22:08 ` Dave Chinner
2012-10-31 10:19 ` Christoph Hellwig
2012-10-30 13:44 ` Phil White
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030134118.GJ18595@caliban.engr.sgi.com \
--to=pwhite@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox