From: Dave Chinner <david@fromorbit.com>
To: Phil White <pwhite@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 07/25] xfs: verify AGI blocks as they are read from disk
Date: Wed, 31 Oct 2012 09:13:33 +1100 [thread overview]
Message-ID: <20121030221333.GB29378@dastard> (raw)
In-Reply-To: <20121030005321.GI30227@caliban.engr.sgi.com>
On Mon, Oct 29, 2012 at 05:53:22PM -0700, Phil White wrote:
> On Thu, Oct 25, 2012 at 05:33:56PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Add an AGI block verify callback function and pass it into the
> > buffer read functions. Remove the now redundant verification code
> > that is currently in use.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > ---
> > fs/xfs/xfs_ialloc.c | 47 ++++++++++++++++++++++++++---------------------
> > 1 file changed, 26 insertions(+), 21 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c
> > index 7c944e1..9311ae5 100644
> > --- a/fs/xfs/xfs_ialloc.c
> > +++ b/fs/xfs/xfs_ialloc.c
> > @@ -1472,6 +1472,31 @@ xfs_check_agi_unlinked(
> > #define xfs_check_agi_unlinked(agi)
> > #endif
> >
> > +static void
> > +xfs_agi_read_verify(
> > + struct xfs_buf *bp)
> > +{
> > + struct xfs_mount *mp = bp->b_target->bt_mount;
> > + struct xfs_agi *agi = XFS_BUF_TO_AGI(bp);
> > + int agi_ok;
> > +
> > + /*
> > + * Validate the magic number of the agi block.
> > + */
> > + agi_ok = agi->agi_magicnum == cpu_to_be32(XFS_AGI_MAGIC) &&
> > + XFS_AGI_GOOD_VERSION(be32_to_cpu(agi->agi_versionnum)) &&
> > + be32_to_cpu(agi->agi_seqno) == bp->b_pag->pag_agno;
> > + if (unlikely(XFS_TEST_ERROR(!agi_ok, mp, XFS_ERRTAG_IALLOC_READ_AGI,
> > + XFS_RANDOM_IALLOC_READ_AGI))) {
> > + XFS_CORRUPTION_ERROR("xfs_read_agi", XFS_ERRLEVEL_LOW,
> > + mp, agi);
> > + xfs_buf_ioerror(bp, EFSCORRUPTED);
> > + }
> > + xfs_check_agi_unlinked(agi);
> > + bp->b_iodone = NULL;
> > + xfs_buf_ioend(bp, 0);
> > +}
> > +
>
> In like fashion, shouldn't this be XFS_CORRUPTION_ERROR("xfs_agi_read_verify",
> ...)? In principle, it might be called from somewhere else in the future.
It should be converted to __func__. I thought I caught most of them,
but I didn't. It's not immediately critical - if I need to repost
the series, I'll fix them.
Most of these messages get revamped when CRC checking is enabled,
anyway, because there are different errors and more useful
information that is worth reporting. hence I haven't been too
concerned about little things like this...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-30 22:11 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 6:33 [PATCH 00/25, V3] xfs: metadata buffer verifiers Dave Chinner
2012-10-25 6:33 ` [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks Dave Chinner
2012-10-30 0:17 ` Phil White
2012-10-25 6:33 ` [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list Dave Chinner
2012-10-26 8:47 ` Christoph Hellwig
2012-10-30 0:22 ` Phil White
2012-10-25 6:33 ` [PATCH 03/25] xfs: make buffer read verication an IO completion function Dave Chinner
2012-10-30 0:29 ` Phil White
2012-10-30 0:45 ` Dave Chinner
2012-10-30 0:55 ` Phil White
2012-10-25 6:33 ` [PATCH 04/25] xfs: uncached buffer reads need to return an error Dave Chinner
2012-10-26 8:48 ` Christoph Hellwig
2012-10-30 0:36 ` Phil White
2012-10-25 6:33 ` [PATCH 05/25] xfs: verify superblocks as they are read from disk Dave Chinner
2012-10-30 0:48 ` Phil White
2012-10-25 6:33 ` [PATCH 06/25] xfs: verify AGF blocks " Dave Chinner
2012-10-30 0:51 ` Phil White
2012-10-25 6:33 ` [PATCH 07/25] xfs: verify AGI " Dave Chinner
2012-10-30 0:53 ` Phil White
2012-10-30 22:13 ` Dave Chinner [this message]
2012-10-25 6:33 ` [PATCH 08/25] xfs: verify AGFL " Dave Chinner
2012-10-30 1:00 ` Phil White
2012-10-25 6:33 ` [PATCH 09/25] xfs: verify inode buffers " Dave Chinner
2012-10-30 1:06 ` Phil White
2012-10-25 6:33 ` [PATCH 10/25] xfs: verify btree blocks " Dave Chinner
2012-10-30 1:14 ` Phil White
2012-10-25 6:34 ` [PATCH 11/25] xfs: verify dquot " Dave Chinner
2012-10-30 1:36 ` Phil White
2012-10-25 6:34 ` [PATCH 12/25] xfs: add verifier callback to directory read code Dave Chinner
2012-10-30 3:15 ` Phil White
2012-10-25 6:34 ` [PATCH 13/25] xfs: factor dir2 block read operations Dave Chinner
2012-10-30 3:23 ` Phil White
2012-10-30 22:16 ` Dave Chinner
2012-10-25 6:34 ` [PATCH 14/25] xfs: verify dir2 block format buffers Dave Chinner
2012-10-30 3:26 ` Phil White
2012-10-25 6:34 ` [PATCH 15/25] xfs: factor dir2 free block reading Dave Chinner
2012-10-30 13:14 ` Phil White
2012-10-25 6:34 ` [PATCH 16/25] xfs: factor out dir2 data " Dave Chinner
2012-10-30 13:21 ` Phil White
2012-10-25 6:34 ` [PATCH 17/25] xfs: factor dir2 leaf read Dave Chinner
2012-10-30 13:22 ` Phil White
2012-10-25 6:34 ` [PATCH 18/25] xfs: factor and verify attr leaf reads Dave Chinner
2012-10-30 13:26 ` Phil White
2012-10-25 6:34 ` [PATCH 19/25] xfs: add xfs_da_node verification Dave Chinner
2012-10-30 13:30 ` Phil White
2012-10-30 22:23 ` Dave Chinner
2012-10-31 0:23 ` Phil White
2012-10-31 0:50 ` Dave Chinner
2012-10-25 6:34 ` [PATCH 20/25] xfs: Add verifiers to dir2 data readahead Dave Chinner
2012-10-30 13:31 ` Phil White
2012-10-25 6:34 ` [PATCH 21/25] xfs: add buffer pre-write callback Dave Chinner
2012-10-26 8:50 ` Christoph Hellwig
2012-10-30 22:30 ` Dave Chinner
2012-10-31 10:20 ` Christoph Hellwig
2012-10-30 13:32 ` Phil White
2012-10-25 6:34 ` [PATCH 22/25] xfs: add pre-write metadata buffer verifier callbacks Dave Chinner
2012-10-30 13:34 ` Phil White
2012-10-25 6:34 ` [PATCH 23/25] xfs: connect up write verifiers to new buffers Dave Chinner
2012-10-30 13:39 ` Phil White
2012-10-30 22:34 ` Dave Chinner
2012-10-25 6:34 ` [PATCH 24/25] xfs: convert buffer verifiers to an ops structure Dave Chinner
2012-10-30 13:41 ` Phil White
2012-10-25 6:34 ` [PATCH 25/25] xfs: add write verifiers to log recovery Dave Chinner
2012-10-26 8:54 ` Christoph Hellwig
2012-10-26 20:31 ` Dave Chinner
2012-10-30 12:23 ` Christoph Hellwig
2012-10-30 22:08 ` Dave Chinner
2012-10-31 10:19 ` Christoph Hellwig
2012-10-30 13:44 ` Phil White
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030221333.GB29378@dastard \
--to=david@fromorbit.com \
--cc=pwhite@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox