From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Engelhardt <jengelh@inai.de>,
Rich Johnston <rjohnston@sgi.com>,
xfs@oss.sgi.com
Subject: Re: [patch 0/2] dmapi: build system revamp
Date: Wed, 31 Oct 2012 08:59:02 -0500 [thread overview]
Message-ID: <20121031135902.GE405@sgi.com> (raw)
In-Reply-To: <20121031102153.GA1111@infradead.org>
Hey Christoph,
On Wed, Oct 31, 2012 at 06:21:53AM -0400, Christoph Hellwig wrote:
> On Tue, Oct 30, 2012 at 04:01:52PM -0500, Ben Myers wrote:
> > Hi,
> >
> > Here are Jan Engelhardt's patches originally posted here
> > http://oss.sgi.com/archives/xfs/2012-05/msg00323.html
> > as they apply to dmapi.
> >
> > Patch 2 applied without much modification, patch 3 was not necessary for dmapi,
> > and patch 6 did not apply at all so I implemented that.
>
> All the patches in this and the related series look good to me.
> but can you please remove the [PATCH N/N] already in the quilt series?
>
> Right now we have one [patch n/n] generated by quilt and then another
> mismatching one, which I think would even land in the git commit log.
Aha. I will clean up the extra [patch n/n]. I didn't expect it would do that.
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for the review!
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-31 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 21:01 [patch 0/2] dmapi: build system revamp Ben Myers
2012-10-30 21:01 ` [patch 1/2] [PATCH 2/6] dmapi: build: use new autoconf constructs Ben Myers
2012-10-30 21:01 ` [patch 2/2] [PATCH 6/6] dmapi: Update .gitignore Ben Myers
2012-10-31 10:21 ` [patch 0/2] dmapi: build system revamp Christoph Hellwig
2012-10-31 13:59 ` Ben Myers [this message]
2012-10-31 17:00 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031135902.GE405@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=jengelh@inai.de \
--cc=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox