From: Ben Myers <bpm@sgi.com>
To: Nathan Scott <nathans@debian.org>
Cc: xfs@oss.sgi.com
Subject: Re: [patch 1/4] xfstests: update version and changelog
Date: Thu, 1 Nov 2012 11:20:16 -0500 [thread overview]
Message-ID: <20121101162016.GC9783@sgi.com> (raw)
In-Reply-To: <1066591451.20029469.1351717231452.JavaMail.root@redhat.com>
Hey Nathan,
On Wed, Oct 31, 2012 at 05:00:31PM -0400, Nathan Scott wrote:
> They all look good to me, thanks Ben. One minor thought,
> for future updates...
>
> ----- Original Message -----
> > ...
> > Index: b/VERSION
> > ===================================================================
> > --- a/VERSION 2012-10-31 13:44:44.931946786 -0500
> > +++ b/VERSION 2012-10-31 13:44:50.832006406 -0500
> > @@ -3,5 +3,5 @@
> > #
> > PKG_MAJOR=1
> > PKG_MINOR=1
> > -PKG_REVISION=0
> > +PKG_REVISION=1
> > PKG_BUILD=1
> > Index: b/configure.ac
> > ===================================================================
> > --- a/configure.ac 2012-10-31 13:45:41.661946816 -0500
> > +++ b/configure.ac 2012-10-31 13:45:48.072005921 -0500
> > @@ -1,4 +1,4 @@
> > -AC_INIT([xfstests], [1.1.0])
> > +AC_INIT([xfstests], [1.1.1])
> > AC_PREREQ(2.50)
> > AC_CONFIG_SRCDIR([src/xfsctl.c])
> > AC_PACKAGE_GLOBALS(xfstests)
>
> I wonder if generating the VERSION file from configure makes
> sense, since we are duplicating that info nowadays?
I think it's a good idea. There are a few other deps on PKG_* so maybe it
would be better to just have configure.ac use PKG* instead of hard coding the
version there.
> Oh, feel free to add Reviewed-by me for all of these patches,
> if you like.
Cool, thanks!
Regards,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-01 16:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 19:25 [patch 0/4] xfs-userspace: update version and changelogs Ben Myers
2012-10-31 19:25 ` [patch 1/4] xfstests: update version and changelog Ben Myers
2012-10-31 21:00 ` Nathan Scott
2012-11-01 16:20 ` Ben Myers [this message]
2012-10-31 19:25 ` [patch 2/4] xfsprogs: " Ben Myers
2012-10-31 19:25 ` [patch 3/4] xfsdump: " Ben Myers
2012-10-31 21:07 ` Nathan Scott
2012-10-31 21:13 ` Ben Myers
2012-10-31 19:25 ` [patch 4/4] dmapi: " Ben Myers
2012-10-31 19:51 ` [patch 0/4] xfs-userspace: update version and changelogs Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101162016.GC9783@sgi.com \
--to=bpm@sgi.com \
--cc=nathans@debian.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox