From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	qA2CxkTF129304 for <xfs@oss.sgi.com>; Fri, 2 Nov 2012 07:59:47 -0500
Received: from bombadil.infradead.org
	(173-166-109-252-newengland.hfc.comcastbusiness.net
	[173.166.109.252]) by cuda.sgi.com with ESMTP id
	dGgo5zPa1aETolrl (version=TLSv1 cipher=AES256-SHA bits=256
	verify=NO) for <xfs@oss.sgi.com>;
	Fri, 02 Nov 2012 06:01:38 -0700 (PDT)
Date: Fri, 2 Nov 2012 09:01:32 -0400
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/2 V2] xfs_logprint: Handle multiply-logged inode fields
Message-ID: <20121102130132.GA12578@infradead.org>
References: <5092A1DE.10609@redhat.com> <5092A2B6.2000907@redhat.com>
	<5092A46A.8080909@sandeen.net>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <5092A46A.8080909@sandeen.net>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>

> I've tested this by a simple test such as creating one
> file on an selinux box, so that data+attr is set, and
> logprinting; I've also tested by running logprint after
> subsequent xfstest runs (although we hit other bugs that
> way).

Can you add this test to xfstests, please?

> +
> +    if (f->ilf_fields & (XFS_ILOG_DEV | XFS_ILOG_UUID)) {
> +	switch (f->ilf_fields & (XFS_ILOG_DEV | XFS_ILOG_UUID)) {
> +	case XFS_ILOG_DEV:
> +	    printf(_("DEV inode: no extra region\n"));

The if here looks odd, I think you should follow the style with
a switch on a masked value as it's done in xlog_recover_inode_pass2()
in the kernel.

I also reall hate the indentation in this function, can you thrown in
a preparatory patch to change it to the normal one?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs