Re: [PATCH 1/2 V2] xfs_logprint: Handle multiply-logged inode fields

Christoph Hellwig
2012-11-02T12:59:47Z

> I've tested this by a simple test such as creating one
> file on an selinux box, so that data+attr is set, and
> logprinting; I've also tested by running logprint after
> subsequent xfstest runs (although we hit other bugs that
> way).

Can you add this test to xfstests, please?

> +
> + if (f->ilf_fields & (XFS_ILOG_DEV | XFS_ILOG_UUID)) {
> + switch (f->ilf_fields & (XFS_ILOG_DEV | XFS_ILOG_UUID)) {
> + case XFS_ILOG_DEV:
> + printf(_("DEV inode: no extra region\n"));

The if here looks odd, I think you should follow the style with
a switch on a masked value as it's done in xlog_recover_inode_pass2()
in the kernel.

I also reall hate the indentation in this function, can you thrown in
a preparatory patch to change it to the normal one?