Re: [PATCH] xfs: report projid32bit feature in geometry call

Eric Sandeen
2012-10-11T00:00:37Z

On 10/9/12 2:11 PM, Eric Sandeen wrote:
> When xfs gained the projid32bit feature, it was never added to
> the FSGEOMETRY ioctl feature flags, so it's not queryable without
> this patch.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

SGI, can you please add a :

Cc: stable@vger.kernel.org

when this is committed? New stuff will be depending on this and it'd be good to get it munged into stable kernels as well.

> ---
>
> note1: is there a reason we had gaps in the flags?
> note2: I don't *think* this requires a new version for the ioctl
>
> diff --git a/fs/xfs/xfs_fs.h b/fs/xfs/xfs_fs.h
> index c13fed8..0948c04 100644
> --- a/fs/xfs/xfs_fs.h
> +++ b/fs/xfs/xfs_fs.h
> @@ -233,7 +233,8 @@ typedef struct xfs_fsop_resblks {
> #define XFS_FSOP_GEOM_FLAGS_LOGV2 0x0100 /* log format version 2 */
> #define XFS_FSOP_GEOM_FLAGS_SECTOR 0x0200 /* sector sizes >1BB */
> #define XFS_FSOP_GEOM_FLAGS_ATTR2 0x0400 /* inline attributes rework */
> -#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */
> +#define XFS_FSOP_GEOM_FLAGS_PROJID32 0x0800 /* 32-bit project IDs */
> +#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */
> #define XFS_FSOP_GEOM_FLAGS_LAZYSB 0x4000 /* lazy superblock counters */
>
>
> diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
> index c25b094..89ad847 100644
> --- a/fs/xfs/xfs_fsops.c
> +++ b/fs/xfs/xfs_fsops.c
> @@ -97,7 +97,9 @@ xfs_fs_geometry(
> (xfs_sb_version_haslazysbcount(&mp->m_sb) ?
> XFS_FSOP_GEOM_FLAGS_LAZYSB : 0) |
> (xfs_sb_version_hasattr2(&mp->m_sb) ?
> - XFS_FSOP_GEOM_FLAGS_ATTR2 : 0);
> + XFS_FSOP_GEOM_FLAGS_ATTR2 : 0) |
> + (xfs_sb_version_hasprojid32bit(&mp->m_sb) ?
> + XFS_FSOP_GEOM_FLAGS_PROJID32 : 0);
> geo->logsectsize = xfs_sb_version_hassector(&mp->m_sb) ?
> mp->m_sb.sb_logsectsize : BBSIZE;
> geo->rtsectsize = mp->m_sb.sb_blocksize;
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs