From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/6] xfs: fix reading of wrapped log data
Date: Sat, 3 Nov 2012 10:51:30 +1100 [thread overview]
Message-ID: <20121102235130.GC29378@dastard> (raw)
In-Reply-To: <20121102130700.GE12578@infradead.org>
On Fri, Nov 02, 2012 at 09:07:00AM -0400, Christoph Hellwig wrote:
> On Fri, Nov 02, 2012 at 11:38:44AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Commit 4439647 ("xfs: reset buffer pointers before freeing them") in
> > 3.0-rc1 introduced a regression when recovering log buffers that
> > wrapped around the end of log. The second part of the log buffer at
> > the start of the physical log was being read into the header buffer
> > rather than the data buffer, and hence recovery was seeing garbage
> > in the data buffer when it got to the region of the log buffer that
> > was incorrectly read.
>
> I think you mentioned earlier you found a reproducer for this, any
> chance it could be added to xfstests?
My reproducer is specific to the hardware I was testing on and
various filesystem parameters (e.g. log size, RAM, writeback rates
to storage, etc), and it was dependent on compilebench to generate
the load. I've been trying to isolate it down to a reproducable case
simliar to test 016, but I haven't quite got it there yet.
And, yes, I very much want a test that covers recovery of wrapped
log buffers. I was very surprised when I realised that it wasnt'
specifically tested by xfstests....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-02 23:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 0:38 [PATCH 0/6] xfs: fixes for 3.7-rc3 Dave Chinner
2012-11-02 0:38 ` [PATCH 1/6] xfs: silence uninitialised f.file warning Dave Chinner
2012-11-02 13:04 ` Christoph Hellwig
2012-11-02 21:23 ` Mark Tinguely
2012-11-02 0:38 ` [PATCH 2/6] xfs: growfs: don't read garbage for new secondary superblocks Dave Chinner
2012-11-02 0:38 ` [PATCH 3/6] xfs: invalidate allocbt blocks moved to the free list Dave Chinner
2012-10-09 19:11 ` [PATCH] xfs: report projid32bit feature in geometry call Eric Sandeen
2012-10-09 19:28 ` Carlos Maiolino
2012-10-09 19:45 ` Dave Chinner
2012-10-11 0:02 ` Eric Sandeen
2012-10-30 19:43 ` Ben Myers
2012-10-30 19:44 ` Eric Sandeen
2012-11-08 16:12 ` Ben Myers
2012-11-02 21:23 ` [PATCH 3/6] xfs: invalidate allocbt blocks moved to the free list Mark Tinguely
2012-11-02 0:38 ` [PATCH 4/6] xfs: don't vmap inode cluster buffers during free Dave Chinner
2012-11-02 13:05 ` Christoph Hellwig
2012-11-02 21:24 ` Mark Tinguely
2012-11-02 0:38 ` [PATCH 5/6] xfs: fix buffer shudown reference count mismatch Dave Chinner
2012-11-02 2:43 ` Dave Chinner
2012-11-02 3:23 ` [PATCH 5/6 V2] " Dave Chinner
2012-11-02 13:17 ` Mark Tinguely
2012-11-02 13:13 ` [PATCH 5/6] " Christoph Hellwig
2012-11-02 17:10 ` Mark Tinguely
2012-11-02 23:47 ` Dave Chinner
2012-11-06 12:59 ` Christoph Hellwig
2012-11-06 19:59 ` Dave Chinner
2012-11-02 0:38 ` [PATCH 6/6] xfs: fix reading of wrapped log data Dave Chinner
2012-11-02 13:07 ` Christoph Hellwig
2012-11-02 23:51 ` Dave Chinner [this message]
2012-11-02 21:24 ` Mark Tinguely
2012-11-07 20:56 ` [PATCH 0/6] xfs: fixes for 3.7-rc3 Dave Chinner
2012-11-08 16:34 ` Ben Myers
2012-11-08 16:15 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102235130.GC29378@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox