From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qA8HhC02011004 for ; Thu, 8 Nov 2012 11:43:12 -0600 Date: Thu, 8 Nov 2012 11:45:08 -0600 From: Ben Myers Subject: Re: [PATCH] xfs: Update inode alloc comments Message-ID: <20121108174508.GO9783@sgi.com> References: <1350742099-8397-1-git-send-email-cmaiolino@redhat.com> <20121102221244.GI9783@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20121102221244.GI9783@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Carlos Maiolino Cc: xfs@oss.sgi.com On Fri, Nov 02, 2012 at 05:12:44PM -0500, Ben Myers wrote: > Hey Carlos, > > On Sat, Oct 20, 2012 at 11:08:19AM -0300, Carlos Maiolino wrote: > > I found some out of date comments while studying the inode allocation code, so I > > believe it's worth to have these comments updated. > > > > It basically rewrites the comment regarding to "call_again" variable, which is > > not used anymore, but instead, callers of xfs_ialloc() decides if it needs to be > > called again relying only if ialloc_context is NULL or not. > > > > Also did some small changes in another comment that I thought to be pertinent > > to the current behaviour of these functions and some alignment on both comments. > > > > Signed-off-by: Carlos Maiolino > > --- > > fs/xfs/xfs_ialloc.c | 6 +++--- > > fs/xfs/xfs_inode.c | 18 +++++++++--------- > > 2 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c > > index 445bf1a..f1a6046 100644 > > --- a/fs/xfs/xfs_ialloc.c > > +++ b/fs/xfs/xfs_ialloc.c > > @@ -876,9 +876,9 @@ error0: > > * This function is designed to be called twice if it has to do an allocation > > * to make more free inodes. On the first call, *IO_agbp should be set to NULL. > > * If an inode is available without having to performn an allocation, an inode > > - * number is returned. In this case, *IO_agbp would be NULL. If an allocation > > - * needes to be done, xfs_dialloc would return the current AGI buffer in > > - * *IO_agbp. The caller should then commit the current transaction, allocate a > > + * number is returned. In this case, *IO_agbp is set to NULL. If an allocation > > + * needes to be done, xfs_dialloc returns the current AGI buffer in *IO_agbp. > needs > > Since we're at it. > > Looks fine. > > Reviewed-by: Ben Myers Carlos, Committed this to git://oss.sgi.com/xfs/xfs.git, master & for-next on Nov 2. -Ben _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs