From: Dave Chinner <david@fromorbit.com>
To: "yyq@eisoo.com" <yyq@eisoo.com>
Cc: xfs@oss.sgi.com
Subject: Re: xfs_quota -x -c 'report -u /dev/sde5' shows the duplicate result.
Date: Fri, 9 Nov 2012 18:01:12 +1100 [thread overview]
Message-ID: <20121109070112.GB6434@dastard> (raw)
In-Reply-To: <509CA82F.7030103@eisoo.com>
On Fri, Nov 09, 2012 at 02:52:31PM +0800, yyq@eisoo.com wrote:
> 于 2012-11-9 13:39, Dave Chinner 写道:
> >On Fri, Nov 09, 2012 at 11:27:33AM +0800, yyq@eisoo.com wrote:
> >>于 2012-11-9 9:24, Dave Chinner 写道:
> >>>On Fri, Nov 09, 2012 at 09:12:37AM +0800, yyq@eisoo.com wrote:
> >>>>Hi,
> >>>>
> >>>> When I use "xfs_quota -x -c 'report -u /dev/sde5'" to show
> >>>>/dev/sde5's quotas, and the result have two same block as below:
> >>>What version of xfs_quota are you using? What is the output of
> >>>/proc/mounts and /etc/mtab say?
> >>xfs_quota's version is 3.1.1 and output of /proc/mounts like this:
....
> >Can you attach the strace output of the command?
Thanks. The patch below should fix it. Can you try it?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
xfs_quota: fix report command parsing
From: Dave Chinner <dchinner@redhat.com>
The report command line needs to be parsed as a whole not as
individual elements - report_f() is set up to do this correctly.
When treated as non-global command line, the report function is
called once for each command line arg, resulting in reports being
issued multiple times.
Set the command to be a global command so that it is only called
once.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
quota/report.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/quota/report.c b/quota/report.c
index a1e165b..70894a2 100644
--- a/quota/report.c
+++ b/quota/report.c
@@ -653,6 +653,7 @@ report_init(void)
report_cmd.cfunc = report_f;
report_cmd.argmin = 0;
report_cmd.argmax = -1;
+ report_cmd.flags = CMD_FLAG_GLOBAL;
report_cmd.args = _("[-bir] [-gpu] [-ahnt] [-f file]");
report_cmd.oneline = _("report filesystem quota information");
report_cmd.help = report_help;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-11-09 6:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 22:23 [patch 0/2] xfs: xfs_tosspages() bug adahl
2012-11-08 22:23 ` [patch 1/2] " Andrew Dahl
2012-11-08 23:06 ` Dave Chinner
2012-11-08 23:46 ` Ben Myers
2012-11-09 1:05 ` Dave Chinner
2012-11-09 17:32 ` Ben Myers
2012-11-08 22:23 ` [patch 2/2] xfstests: xfs_tosspages() test addition Andrew Dahl
2012-11-08 23:27 ` Dave Chinner
2012-11-13 1:13 ` [patch 2/2 V2] " Andrew Dahl
2012-11-14 18:00 ` Mark Tinguely
2012-11-14 18:35 ` Andrew Dahl
2012-11-14 18:57 ` [patch 2/2 V3] " Andrew Dahl
2012-11-14 20:34 ` Dave Chinner
2012-11-20 15:31 ` Mark Tinguely
2012-11-09 1:12 ` xfs_quota -x -c 'report -u /dev/sde5' shows the duplicate result yyq
2012-11-09 1:24 ` Dave Chinner
2012-11-09 3:27 ` yyq
2012-11-09 5:39 ` Dave Chinner
[not found] ` <509CA82F.7030103@eisoo.com>
2012-11-09 7:01 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121109070112.GB6434@dastard \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
--cc=yyq@eisoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox