From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qAD0MNSC001100 for ; Mon, 12 Nov 2012 18:22:23 -0600 Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id 0SuaSAqhKswVYwKL for ; Mon, 12 Nov 2012 16:24:25 -0800 (PST) Date: Tue, 13 Nov 2012 11:24:20 +1100 From: Dave Chinner Subject: Re: xfs: Use bool type rather than a custom boolean_t type. Message-ID: <20121113002420.GC25039@dastard> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Thiago Farina Cc: Ben Myers , Alex Elder , linux list , xfs@oss.sgi.com On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote: > Hi, > > Please, take a look. > > Patch attached. It's a good start for a cleanup, but there's no point in removing the boolean_t from one file and then not removing it from the rest of the XFS code. It's only used in a handful of places, so just remove it completely. Also, can you please place patches in line rather than attaching them. Attaching them means they cannot be quoted in reply. See Documentation/SubmittingPatches and Documentation/email-clients.txt for guidelines. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs