xfs: Use bool type rather than a custom boolean_t type.

xfs: Use bool type rather than a custom boolean_t type.

[Thiago Farina]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

Hi,

Please, take a look.

Patch attached.

Thanks,

[-- Attachment #2: 0001-xfs-Use-bool-type-rather-than-a-custom-boolean_t-typ.patch --]
[-- Type: application/octet-stream, Size: 1680 bytes --]

From 65e8e95caec8e187d873c6c1451ab00ff131dbe4 Mon Sep 17 00:00:00 2001
From: Thiago Farina <tfarina@chromium.org>
Date: Mon, 12 Nov 2012 21:32:59 -0200
Subject: [PATCH] xfs: Use bool type rather than a custom boolean_t type.

Signed-off-by: Thiago Farina <tfarina@chromium.org>
---
 fs/xfs/xfs_log.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 4dad756..4e7eb76 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -118,7 +118,7 @@ xlog_verify_iclog(
 	struct xlog		*log,
 	struct xlog_in_core	*iclog,
 	int			count,
-	boolean_t		syncing);
+	bool                    syncing);
 STATIC void
 xlog_verify_tail_lsn(
 	struct xlog		*log,
@@ -3451,7 +3451,7 @@ xlog_verify_iclog(
 	struct xlog		*log,
 	struct xlog_in_core	*iclog,
 	int			count,
-	boolean_t		syncing)
+	bool                    syncing)
 {
 	xlog_op_header_t	*ophead;
 	xlog_in_core_t		*icptr;
@@ -3499,7 +3499,7 @@ xlog_verify_iclog(
 		/* clientid is only 1 byte */
 		field_offset = (__psint_t)
 			       ((xfs_caddr_t)&(ophead->oh_clientid) - base_ptr);
-		if (syncing == B_FALSE || (field_offset & 0x1ff)) {
+		if (!syncing || (field_offset & 0x1ff)) {
 			clientid = ophead->oh_clientid;
 		} else {
 			idx = BTOBBT((xfs_caddr_t)&(ophead->oh_clientid) - iclog->ic_datap);
@@ -3522,7 +3522,7 @@ xlog_verify_iclog(
 		/* check length */
 		field_offset = (__psint_t)
 			       ((xfs_caddr_t)&(ophead->oh_len) - base_ptr);
-		if (syncing == B_FALSE || (field_offset & 0x1ff)) {
+		if (!syncing || (field_offset & 0x1ff)) {
 			op_len = be32_to_cpu(ophead->oh_len);
 		} else {
 			idx = BTOBBT((__psint_t)&ophead->oh_len -
-- 
1.8.0.rc2


[-- Attachment #3: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfs: Use bool type rather than a custom boolean_t type.

[Dave Chinner]

On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote:
> Hi,
> 
> Please, take a look.
> 
> Patch attached.

It's a good start for a cleanup, but there's no point in removing
the boolean_t from one file and then not removing it from the rest
of the XFS code.  It's only used in a handful of places, so just
remove it completely.

Also, can you please place patches in line rather than attaching
them. Attaching them means they cannot be quoted in reply. See
Documentation/SubmittingPatches and Documentation/email-clients.txt
for guidelines.

Cheers,

Dave.

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs