From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qAFGMDYU015338 for ; Thu, 15 Nov 2012 10:22:13 -0600 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id YvloG2e0vvw3JLNe (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 15 Nov 2012 08:24:18 -0800 (PST) Date: Thu, 15 Nov 2012 11:24:17 -0500 From: Christoph Hellwig Subject: Re: [PATCH 04/32] xfs: remove xfs_flush_pages Message-ID: <20121115162417.GD4019@infradead.org> References: <1352721264-3700-1-git-send-email-david@fromorbit.com> <1352721264-3700-5-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1352721264-3700-5-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Mon, Nov 12, 2012 at 10:53:56PM +1100, Dave Chinner wrote: > From: Dave Chinner > > It is a complex wrapper around VFS functions, but there are VFS > functions that provide exactly the same functionality. Call the VFS > functions directly and remove the unnecessary indirection and > complexity. > > We don't need to care about clearing the XFS_ITRUNCATED flag, as > that is done during .writepages. Hence is cleared by the VFS > writeback path if there is anything to write back during the flush. > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs