From: Dave Chinner <david@fromorbit.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Ben Myers <bpm@sgi.com>,
xfs@oss.sgi.com, Dave Chinner <dchinner@redhat.com>
Subject: Re: [xfs:for-next 68/70] fs/xfs/xfs_ialloc_btree.c:186:1: sparse: symbol 'xfs_inobt_verify' was not declared. Should it be static?
Date: Sun, 18 Nov 2012 10:30:57 +1100 [thread overview]
Message-ID: <20121117233057.GR14281@dastard> (raw)
In-Reply-To: <50a5e062.XN/BRFaWJHYKYG4f%fengguang.wu@intel.com>
On Fri, Nov 16, 2012 at 02:42:42PM +0800, kbuild test robot wrote:
> tree: git://oss.sgi.com/xfs/xfs for-next
> head: 1813dd64057490e7a0678a885c4fe6d02f78bdc1
> commit: 612cfbfe174a89d565363fff7f3961a2dda5fb71 [68/70] xfs: add pre-write metadata buffer verifier callbacks
>
>
> sparse warnings:
>
> + fs/xfs/xfs_ialloc_btree.c:186:1: sparse: symbol 'xfs_inobt_verify' was not declared. Should it be static?
> fs/xfs/xfs_ialloc_btree.c:227:1: sparse: symbol 'xfs_inobt_read_verify' was not declared. Should it be static?
Hi Fengguang,
For a short while these probably should be static, but they will be
externally visible soon - there are subsequent patches that will hit
3.9 require this to be available externally, so I'm not sure it's
worth fixing this right now, only to change it back again shortly.
> Please consider folding the attached diff :-)
No, because it changes more than just what the above sparse error
reports.....
> diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c
> index b38a10e..6a714b5 100644
> --- a/fs/xfs/xfs_dquot.c
> +++ b/fs/xfs/xfs_dquot.c
> @@ -52,10 +52,10 @@
> */
>
> #ifdef DEBUG
> -xfs_buftarg_t *xfs_dqerror_target;
> -int xfs_do_dqerror;
> -int xfs_dqreq_num;
> -int xfs_dqerror_mod = 33;
> +static xfs_buftarg_t *xfs_dqerror_target;
> +static int xfs_do_dqerror;
> +static int xfs_dqreq_num;
> +static int xfs_dqerror_mod = 33;
> #endif
These are debug build only, and intended to be globally visible so
they can be changed with a debugger. And sparse didn't warn about
them, because you didn't do a debug build, so the script shouldn't
be changing them.(*)
Cheers,
Dave.
(*) Please don't do debug XFS builds with this automated checker. We
pretty much turn all static functions to global "noinline" functions
for debug builds, and sparse will throw hundreds of useless warnings.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-17 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 6:42 [xfs:for-next 68/70] fs/xfs/xfs_ialloc_btree.c:186:1: sparse: symbol 'xfs_inobt_verify' was not declared. Should it be static? kbuild test robot
2012-11-17 23:30 ` Dave Chinner [this message]
2012-11-18 4:02 ` Fengguang Wu
2012-11-18 23:53 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121117233057.GR14281@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=dchinner@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox