From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Ben England <bengland@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH, RFC] mkfs.xfs: go into multidisk mode when geometry is on cmdline
Date: Wed, 21 Nov 2012 04:56:36 -0500 [thread overview]
Message-ID: <20121121095636.GC23339@infradead.org> (raw)
In-Reply-To: <50ABB115.9070905@sandeen.net>
On Tue, Nov 20, 2012 at 10:34:29AM -0600, Eric Sandeen wrote:
> So now for a ~5T fs, for example, we'd make several more
> AGs:
>
> # truncate --size=5t fsfile
> # mkfs.xfs -N -d su=128k,sw=8 fsfile | grep agcount
> meta-data=fsfile isize=256 agcount=5, agsize=268435424 blks
> # mkfs/mkfs.xfs -N -d su=128k,sw=8 fsfile | grep agcount
> meta-data=fsfile isize=256 agcount=32, agsize=41943008 blks
Can you add this to xfstests, please?
> TBH, though, is there ever any value in treating a very large
> fs as "!multidisk?" When would we ever want to pretend that
> a 16T filesystem doesn't have a lot of spindles behind it?
Not now, but I'm pretty sure we'll get there not too soon in the
future.
> + } else if (daflag) /* User-specified AG count */
> + agsize = dblocks / agcount + (dblocks % agcount != 0);
> + else
> + calc_default_ag_geometry(blocklog, dblocks,
> + dsunit | dswidth, &agsize, &agcount);
> +
I know the code was just moved, but can you add braces to the else if
constructs so that the whole if else if else has consistent bracing?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-21 9:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 16:34 [PATCH, RFC] mkfs.xfs: go into multidisk mode when geometry is on cmdline Eric Sandeen
2012-11-21 9:56 ` Christoph Hellwig [this message]
2012-12-06 21:35 ` [PATCH V2] " Eric Sandeen
2012-12-06 21:52 ` [PATCH V3] " Eric Sandeen
2012-12-08 11:59 ` Christoph Hellwig
2012-12-06 22:02 ` [PATCH] xfstests: Ensure cmdline geometry puts mkfs.xfs into multidisk mode Eric Sandeen
2012-12-08 12:00 ` Christoph Hellwig
2012-12-08 16:27 ` Eric Sandeen
2012-12-09 23:51 ` Dave Chinner
2012-12-10 0:23 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121095636.GC23339@infradead.org \
--to=hch@infradead.org \
--cc=bengland@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox