* [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
2012-10-26 16:46 ` Rich Johnston
@ 2012-11-19 3:26 ` sat
2012-11-19 3:55 ` Wanlong Gao
2012-11-20 4:06 ` Eric Sandeen
0 siblings, 2 replies; 10+ messages in thread
From: sat @ 2012-11-19 3:26 UTC (permalink / raw)
To: Rich Johnston; +Cc: Eric Sandeen, xfs mailing list
Hi Rich, Eric
(2012/10/27 1:46), Rich Johnston wrote:
> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>> If you try running xfstests on lvm volumes which are symlinks,
>> it'll fail to run several tests because our _require_scratch
>> framework ultimately uses lstat not stat, and does not think
>> the lvm device (which is usually a symlink to a dm-X device)
>> is a block device. Sigh.
>>
>> Last try at this - just resolve any symlinked devicenames
>> into their realpath(3) in common.config.
>>
>> This actually seems to work.
>>
>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>
>> ---
>>
>>
>> diff --git a/common.config b/common.config
>> index 926846b..e5b2483 100644
>> --- a/common.config
>> +++ b/common.config
>
> Looks good
>
> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>
> Eric,
>
> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Commit d5ea873f is not the same as the the following original Eric's patch.
http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
It does not modify src/Makefile and realpath is never compiled.
In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
if $TEST_DEV or $SCRATCH_DEV are not defined.
Cc: Eric Sandeen <sandeen@sandeen.net>
Cc: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
---
common.config | 4 ++--
src/Makefile | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/common.config b/common.config
index 585b150..3240ee9 100644
--- a/common.config
+++ b/common.config
@@ -221,11 +221,11 @@ else
fi
# Scripts just don't deal well with symlinked devices
-if [ -L $TEST_DEV ]; then
+if [ -L "$TEST_DEV" ]; then
TEST_DEV=`src/realpath $TEST_DEV`
fi
-if [ -L $SCRATCH_DEV ]; then
+if [ -L "$SCRATCH_DEV" ]; then
SCRATCH_DEV=`src/realpath $SCRATCH_DEV`
fi
diff --git a/src/Makefile b/src/Makefile
index f7362a2..9f7281d 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -11,7 +11,7 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \
devzero feature alloc fault fstest t_access_root \
godown resvtest writemod makeextents itrash rename \
multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \
- t_mmap_writev
+ t_mmap_writev realpath
LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
--
1.7.7.6
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
2012-11-19 3:26 ` [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices sat
@ 2012-11-19 3:55 ` Wanlong Gao
2012-11-20 4:06 ` Eric Sandeen
1 sibling, 0 replies; 10+ messages in thread
From: Wanlong Gao @ 2012-11-19 3:55 UTC (permalink / raw)
To: sat; +Cc: Eric Sandeen, Rich Johnston, xfs mailing list
On 11/19/2012 11:26 AM, sat wrote:
> Hi Rich, Eric
>
> (2012/10/27 1:46), Rich Johnston wrote:
>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>> If you try running xfstests on lvm volumes which are symlinks,
>>> it'll fail to run several tests because our _require_scratch
>>> framework ultimately uses lstat not stat, and does not think
>>> the lvm device (which is usually a symlink to a dm-X device)
>>> is a block device. Sigh.
>>>
>>> Last try at this - just resolve any symlinked devicenames
>>> into their realpath(3) in common.config.
>>>
>>> This actually seems to work.
>>>
>>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>>
>>> ---
>>>
>>>
>>> diff --git a/common.config b/common.config
>>> index 926846b..e5b2483 100644
>>> --- a/common.config
>>> +++ b/common.config
>>
>> Looks good
>>
>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>
>> Eric,
>>
>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>
> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>
> Commit d5ea873f is not the same as the the following original Eric's patch.
>
> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>
> It does not modify src/Makefile and realpath is never compiled.
>
> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
> if $TEST_DEV or $SCRATCH_DEV are not defined.
>
> Cc: Eric Sandeen <sandeen@sandeen.net>
> Cc: Rich Johnston <rjohnston@sgi.com>
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>
> ---
> common.config | 4 ++--
> src/Makefile | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/common.config b/common.config
> index 585b150..3240ee9 100644
> --- a/common.config
> +++ b/common.config
> @@ -221,11 +221,11 @@ else
> fi
>
> # Scripts just don't deal well with symlinked devices
> -if [ -L $TEST_DEV ]; then
> +if [ -L "$TEST_DEV" ]; then
> TEST_DEV=`src/realpath $TEST_DEV`
> fi
>
> -if [ -L $SCRATCH_DEV ]; then
> +if [ -L "$SCRATCH_DEV" ]; then
> SCRATCH_DEV=`src/realpath $SCRATCH_DEV`
> fi
>
> diff --git a/src/Makefile b/src/Makefile
> index f7362a2..9f7281d 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -11,7 +11,7 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \
> devzero feature alloc fault fstest t_access_root \
> godown resvtest writemod makeextents itrash rename \
> multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \
> - t_mmap_writev
> + t_mmap_writev realpath
>
> LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
> preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
2012-11-19 3:26 ` [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices sat
2012-11-19 3:55 ` Wanlong Gao
@ 2012-11-20 4:06 ` Eric Sandeen
2012-11-20 4:30 ` sat
1 sibling, 1 reply; 10+ messages in thread
From: Eric Sandeen @ 2012-11-20 4:06 UTC (permalink / raw)
To: sat; +Cc: Rich Johnston, xfs mailing list
On 11/18/12 9:26 PM, sat wrote:
> Hi Rich, Eric
>
> (2012/10/27 1:46), Rich Johnston wrote:
>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>> If you try running xfstests on lvm volumes which are symlinks,
>>> it'll fail to run several tests because our _require_scratch
>>> framework ultimately uses lstat not stat, and does not think
>>> the lvm device (which is usually a symlink to a dm-X device)
>>> is a block device. Sigh.
>>>
>>> Last try at this - just resolve any symlinked devicenames
>>> into their realpath(3) in common.config.
>>>
>>> This actually seems to work.
>>>
>>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>>
>>> ---
>>>
>>>
>>> diff --git a/common.config b/common.config
>>> index 926846b..e5b2483 100644
>>> --- a/common.config
>>> +++ b/common.config
>>
>> Looks good
>>
>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>
>> Eric,
>>
>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>
> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>
> Commit d5ea873f is not the same as the the following original Eric's patch.
>
> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>
> It does not modify src/Makefile and realpath is never compiled.
Yep, whoops. Merge error . . .?
> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
> if $TEST_DEV or $SCRATCH_DEV are not defined.
Well, I don't think ./check will get very far with an undefined TEST_DEV or
SCRATCH_DEV, but better this way, thanks.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> Cc: Eric Sandeen <sandeen@sandeen.net>
> Cc: Rich Johnston <rjohnston@sgi.com>
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>
> ---
> common.config | 4 ++--
> src/Makefile | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/common.config b/common.config
> index 585b150..3240ee9 100644
> --- a/common.config
> +++ b/common.config
> @@ -221,11 +221,11 @@ else
> fi
>
> # Scripts just don't deal well with symlinked devices
> -if [ -L $TEST_DEV ]; then
> +if [ -L "$TEST_DEV" ]; then
> TEST_DEV=`src/realpath $TEST_DEV`
> fi
>
> -if [ -L $SCRATCH_DEV ]; then
> +if [ -L "$SCRATCH_DEV" ]; then
> SCRATCH_DEV=`src/realpath $SCRATCH_DEV`
> fi
>
> diff --git a/src/Makefile b/src/Makefile
> index f7362a2..9f7281d 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -11,7 +11,7 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \
> devzero feature alloc fault fstest t_access_root \
> godown resvtest writemod makeextents itrash rename \
> multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \
> - t_mmap_writev
> + t_mmap_writev realpath
>
> LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
> preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
2012-11-20 4:06 ` Eric Sandeen
@ 2012-11-20 4:30 ` sat
2012-11-20 5:28 ` Eric Sandeen
0 siblings, 1 reply; 10+ messages in thread
From: sat @ 2012-11-20 4:30 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Rich Johnston, xfs mailing list
(2012/11/20 13:06), Eric Sandeen wrote:
> On 11/18/12 9:26 PM, sat wrote:
>> Hi Rich, Eric
>>
>> (2012/10/27 1:46), Rich Johnston wrote:
>>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>>> If you try running xfstests on lvm volumes which are symlinks,
>>>> it'll fail to run several tests because our _require_scratch
>>>> framework ultimately uses lstat not stat, and does not think
>>>> the lvm device (which is usually a symlink to a dm-X device)
>>>> is a block device. Sigh.
>>>>
>>>> Last try at this - just resolve any symlinked devicenames
>>>> into their realpath(3) in common.config.
>>>>
>>>> This actually seems to work.
>>>>
>>>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>>>
>>>> ---
>>>>
>>>>
>>>> diff --git a/common.config b/common.config
>>>> index 926846b..e5b2483 100644
>>>> --- a/common.config
>>>> +++ b/common.config
>>>
>>> Looks good
>>>
>>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>>
>>> Eric,
>>>
>>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>>
>> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>>
>> Commit d5ea873f is not the same as the the following original Eric's patch.
>>
>> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>>
>> It does not modify src/Makefile and realpath is never compiled.
>
> Yep, whoops. Merge error . . .?
>
>> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
>> if $TEST_DEV or $SCRATCH_DEV are not defined.
>
> Well, I don't think ./check will get very far with an undefined TEST_DEV or
> SCRATCH_DEV, but better this way, thanks.
I think so too. But setting $SCRATCH_DEV is optional anyaway (refer to README).
I forgot to specify $SCRATCH_DEV and found this problem.
Satoru
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
2012-11-20 4:30 ` sat
@ 2012-11-20 5:28 ` Eric Sandeen
2012-11-20 13:53 ` Rich Johnston
0 siblings, 1 reply; 10+ messages in thread
From: Eric Sandeen @ 2012-11-20 5:28 UTC (permalink / raw)
To: sat; +Cc: Rich Johnston, xfs mailing list
On 11/19/12 10:30 PM, sat wrote:
> (2012/11/20 13:06), Eric Sandeen wrote:
>> On 11/18/12 9:26 PM, sat wrote:
>>> Hi Rich, Eric
>>>
>>> (2012/10/27 1:46), Rich Johnston wrote:
>>>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>>>> If you try running xfstests on lvm volumes which are symlinks,
>>>>> it'll fail to run several tests because our _require_scratch
>>>>> framework ultimately uses lstat not stat, and does not think
>>>>> the lvm device (which is usually a symlink to a dm-X device)
>>>>> is a block device. Sigh.
>>>>>
>>>>> Last try at this - just resolve any symlinked devicenames
>>>>> into their realpath(3) in common.config.
>>>>>
>>>>> This actually seems to work.
>>>>>
>>>>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>>>>
>>>>> ---
>>>>>
>>>>>
>>>>> diff --git a/common.config b/common.config
>>>>> index 926846b..e5b2483 100644
>>>>> --- a/common.config
>>>>> +++ b/common.config
>>>>
>>>> Looks good
>>>>
>>>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>>>
>>>> Eric,
>>>>
>>>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>>>
>>> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>>>
>>> Commit d5ea873f is not the same as the the following original Eric's patch.
>>>
>>> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>>>
>>> It does not modify src/Makefile and realpath is never compiled.
>>
>> Yep, whoops. Merge error . . .?
>>
>>> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
>>> if $TEST_DEV or $SCRATCH_DEV are not defined.
>>
>> Well, I don't think ./check will get very far with an undefined TEST_DEV or
>> SCRATCH_DEV, but better this way, thanks.
>
> I think so too. But setting $SCRATCH_DEV is optional anyaway (refer to README).
> I forgot to specify $SCRATCH_DEV and found this problem.
Ah, right - yes, that's perfectly valid, sorry. Not thinking straight :)
-Eric
> Satoru
>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
2012-11-20 5:28 ` Eric Sandeen
@ 2012-11-20 13:53 ` Rich Johnston
2012-11-20 14:05 ` Eric Sandeen
0 siblings, 1 reply; 10+ messages in thread
From: Rich Johnston @ 2012-11-20 13:53 UTC (permalink / raw)
To: Eric Sandeen; +Cc: sat, xfs mailing list
On 11/19/2012 11:28 PM, Eric Sandeen wrote:
> On 11/19/12 10:30 PM, sat wrote:
>> (2012/11/20 13:06), Eric Sandeen wrote:
>>> On 11/18/12 9:26 PM, sat wrote:
>>>> Hi Rich, Eric
>>>>
>>>> (2012/10/27 1:46), Rich Johnston wrote:
>>>>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>>>>> If you try running xfstests on lvm volumes which are symlinks,
>>>>>> it'll fail to run several tests because our _require_scratch
>>>>>> framework ultimately uses lstat not stat, and does not think
>>>>>> the lvm device (which is usually a symlink to a dm-X device)
>>>>>> is a block device. Sigh.
>>>>>>
>>>>>> Last try at this - just resolve any symlinked devicenames
>>>>>> into their realpath(3) in common.config.
>>>>>>
>>>>>> This actually seems to work.
>>>>>>
>>>>>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>>>>>
>>>>>> ---
>>>>>>
>>>>>>
>>>>>> diff --git a/common.config b/common.config
>>>>>> index 926846b..e5b2483 100644
>>>>>> --- a/common.config
>>>>>> +++ b/common.config
>>>>>
>>>>> Looks good
>>>>>
>>>>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>>>>
>>>>> Eric,
>>>>>
>>>>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>>>>
>>>> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>>>>
>>>> Commit d5ea873f is not the same as the the following original Eric's patch.
>>>>
>>>> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>>>>
>>>> It does not modify src/Makefile and realpath is never compiled.
>>>
>>> Yep, whoops. Merge error . . .?
Yes sorry my bad.
>>>
>>>> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
>>>> if $TEST_DEV or $SCRATCH_DEV are not defined.
>>>
>>> Well, I don't think ./check will get very far with an undefined TEST_DEV or
>>> SCRATCH_DEV, but better this way, thanks.
>>
>> I think so too. But setting $SCRATCH_DEV is optional anyaway (refer to README).
>> I forgot to specify $SCRATCH_DEV and found this problem.
>
> Ah, right - yes, that's perfectly valid, sorry. Not thinking straight :)
>
> -Eric
Eric, do you have time to correct these 2 errors or do want me submit a
patch?
>
>> Satoru
>>
>>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
2012-11-20 13:53 ` Rich Johnston
@ 2012-11-20 14:05 ` Eric Sandeen
0 siblings, 0 replies; 10+ messages in thread
From: Eric Sandeen @ 2012-11-20 14:05 UTC (permalink / raw)
To: Rich Johnston; +Cc: sat, xfs mailing list
On Nov 20, 2012, at 7:53 AM, Rich Johnston <rjohnston@sgi.com> wrote:
> On 11/19/2012 11:28 PM, Eric Sandeen wrote:
>> On 11/19/12 10:30 PM, sat wrote:
>>> (2012/11/20 13:06), Eric Sandeen wrote:
>>>> On 11/18/12 9:26 PM, sat wrote:
>>>>> Hi Rich, Eric
>>>>>
>>>>> (2012/10/27 1:46), Rich Johnston wrote:
>>>>>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>>>>>> If you try running xfstests on lvm volumes which are symlinks,
>>>>>>> it'll fail to run several tests because our _require_scratch
>>>>>>> framework ultimately uses lstat not stat, and does not think
>>>>>>> the lvm device (which is usually a symlink to a dm-X device)
>>>>>>> is a block device. Sigh.
>>>>>>>
>>>>>>> Last try at this - just resolve any symlinked devicenames
>>>>>>> into their realpath(3) in common.config.
>>>>>>>
>>>>>>> This actually seems to work.
>>>>>>>
>>>>>>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>>>>>>
>>>>>>> ---
>>>>>>>
>>>>>>>
>>>>>>> diff --git a/common.config b/common.config
>>>>>>> index 926846b..e5b2483 100644
>>>>>>> --- a/common.config
>>>>>>> +++ b/common.config
>>>>>>
>>>>>> Looks good
>>>>>>
>>>>>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>>>>>
>>>>>> Eric,
>>>>>>
>>>>>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>>>>>
>>>>> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>>>>>
>>>>> Commit d5ea873f is not the same as the the following original Eric's patch.
>>>>>
>>>>> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>>>>>
>>>>> It does not modify src/Makefile and realpath is never compiled.
>>>>
>>>> Yep, whoops. Merge error . . .?
>
> Yes sorry my bad.
>
>>>>
>>>>> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
>>>>> if $TEST_DEV or $SCRATCH_DEV are not defined.
>>>>
>>>> Well, I don't think ./check will get very far with an undefined TEST_DEV or
>>>> SCRATCH_DEV, but better this way, thanks.
>>>
>>> I think so too. But setting $SCRATCH_DEV is optional anyaway (refer to README).
>>> I forgot to specify $SCRATCH_DEV and found this problem.
>>
>> Ah, right - yes, that's perfectly valid, sorry. Not thinking straight :)
>>
>> -Eric
>
> Eric, do you have time to correct these 2 errors or do want me submit a patch?
>
Satoru had submitted the patch and it has 2 reviews on list, just look up-thread. :)
Eric
>>
>>> Satoru
>>>
>>>
>>
>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
[not found] <20121121135123.092349449@sgi.com>
@ 2012-11-21 13:51 ` rjohnston
2012-11-21 14:31 ` Rich Johnston
2012-11-23 12:37 ` Christoph Hellwig
0 siblings, 2 replies; 10+ messages in thread
From: rjohnston @ 2012-11-21 13:51 UTC (permalink / raw)
To: xfs; +Cc: Satoru Takeuchi, Eric Sandeen
[-- Attachment #1: xfstests-fix-to-build-src-realpath-and-the-correct-the-existence-of-target-devices.patch target devices --]
[-- Type: text/plain, Size: 2877 bytes --]
Hi Rich, Eric
(2012/10/27 1:46), Rich Johnston wrote:
> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>> If you try running xfstests on lvm volumes which are symlinks,
>> it'll fail to run several tests because our _require_scratch
>> framework ultimately uses lstat not stat, and does not think
>> the lvm device (which is usually a symlink to a dm-X device)
>> is a block device. Sigh.
>>
>> Last try at this - just resolve any symlinked devicenames
>> into their realpath(3) in common.config.
>>
>> This actually seems to work.
>>
>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>
>> ---
>>
>>
>> diff --git a/common.config b/common.config
>> index 926846b..e5b2483 100644
>> --- a/common.config
>> +++ b/common.config
>
> Looks good
>
> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>
> Eric,
>
> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Commit d5ea873f is not the same as the the following original Eric's patch.
http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
It does not modify src/Makefile and realpath is never compiled.
In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
if $TEST_DEV or $SCRATCH_DEV are not defined.
Cc: Eric Sandeen <sandeen@sandeen.net>
Cc: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
---
common.config | 4 ++--
common.config | 4 ++--
src/Makefile | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Index: b/common.config
===================================================================
--- a/common.config
+++ b/common.config
@@ -221,11 +221,11 @@ else
fi
# Scripts just don't deal well with symlinked devices
-if [ -L $TEST_DEV ]; then
+if [ -L "$TEST_DEV" ]; then
TEST_DEV=`src/realpath $TEST_DEV`
fi
-if [ -L $SCRATCH_DEV ]; then
+if [ -L "$SCRATCH_DEV" ]; then
SCRATCH_DEV=`src/realpath $SCRATCH_DEV`
fi
Index: b/src/Makefile
===================================================================
--- a/src/Makefile
+++ b/src/Makefile
@@ -11,7 +11,7 @@ TARGETS = dirstress fill fill2 getpagesi
devzero feature alloc fault fstest t_access_root \
godown resvtest writemod makeextents itrash rename \
multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \
- t_mmap_writev
+ t_mmap_writev realpath
LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
2012-11-21 13:51 ` [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices rjohnston
@ 2012-11-21 14:31 ` Rich Johnston
2012-11-23 12:37 ` Christoph Hellwig
1 sibling, 0 replies; 10+ messages in thread
From: Rich Johnston @ 2012-11-21 14:31 UTC (permalink / raw)
To: xfs; +Cc: Satoru Takeuchi, Eric Sandeen
On 11/21/2012 07:51 AM, rjohnston@sgi.com wrote:
This series has been committed to git://oss.sgi.com/xfs/cmds/xfstests
master branch, commit 7459ac.
--Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
2012-11-21 13:51 ` [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices rjohnston
2012-11-21 14:31 ` Rich Johnston
@ 2012-11-23 12:37 ` Christoph Hellwig
1 sibling, 0 replies; 10+ messages in thread
From: Christoph Hellwig @ 2012-11-23 12:37 UTC (permalink / raw)
To: rjohnston; +Cc: Satoru Takeuchi, Eric Sandeen, xfs
On Wed, Nov 21, 2012 at 07:51:24AM -0600, rjohnston@sgi.com wrote:
> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>
> Commit d5ea873f is not the same as the the following original Eric's patch.
>
> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>
> It does not modify src/Makefile and realpath is never compiled.
>
> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
> if $TEST_DEV or $SCRATCH_DEV are not defined.
>
> Cc: Eric Sandeen <sandeen@sandeen.net>
> Cc: Rich Johnston <rjohnston@sgi.com>
Thanks for the fixes, this looks good.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-11-23 12:35 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20121121135123.092349449@sgi.com>
2012-11-21 13:51 ` [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices rjohnston
2012-11-21 14:31 ` Rich Johnston
2012-11-23 12:37 ` Christoph Hellwig
2010-06-08 20:03 [PATCH] xfstests: resolve symlinked devices to real paths Eric Sandeen
2012-10-26 16:46 ` Rich Johnston
2012-11-19 3:26 ` [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices sat
2012-11-19 3:55 ` Wanlong Gao
2012-11-20 4:06 ` Eric Sandeen
2012-11-20 4:30 ` sat
2012-11-20 5:28 ` Eric Sandeen
2012-11-20 13:53 ` Rich Johnston
2012-11-20 14:05 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox