From: Christoph Hellwig <hch@infradead.org>
To: rjohnston@sgi.com
Cc: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>,
Eric Sandeen <sandeen@sandeen.net>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
Date: Fri, 23 Nov 2012 07:37:40 -0500 [thread overview]
Message-ID: <20121123123740.GA12150@infradead.org> (raw)
In-Reply-To: <20121121135210.840563563@sgi.com>
On Wed, Nov 21, 2012 at 07:51:24AM -0600, rjohnston@sgi.com wrote:
> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>
> Commit d5ea873f is not the same as the the following original Eric's patch.
>
> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>
> It does not modify src/Makefile and realpath is never compiled.
>
> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
> if $TEST_DEV or $SCRATCH_DEV are not defined.
>
> Cc: Eric Sandeen <sandeen@sandeen.net>
> Cc: Rich Johnston <rjohnston@sgi.com>
Thanks for the fixes, this looks good.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-23 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121121135123.092349449@sgi.com>
2012-11-21 13:51 ` [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices rjohnston
2012-11-21 14:31 ` Rich Johnston
2012-11-23 12:37 ` Christoph Hellwig [this message]
2010-06-08 20:03 [PATCH] xfstests: resolve symlinked devices to real paths Eric Sandeen
2012-10-26 16:46 ` Rich Johnston
2012-11-19 3:26 ` [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices sat
2012-11-19 3:55 ` Wanlong Gao
2012-11-20 4:06 ` Eric Sandeen
2012-11-20 4:30 ` sat
2012-11-20 5:28 ` Eric Sandeen
2012-11-20 13:53 ` Rich Johnston
2012-11-20 14:05 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123123740.GA12150@infradead.org \
--to=hch@infradead.org \
--cc=rjohnston@sgi.com \
--cc=sandeen@sandeen.net \
--cc=takeuchi_satoru@jp.fujitsu.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox