From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qANCd8k6073091 for ; Fri, 23 Nov 2012 06:39:08 -0600 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id E5nhCuYDBCOfr2yi (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 23 Nov 2012 04:41:20 -0800 (PST) Date: Fri, 23 Nov 2012 07:41:19 -0500 From: Christoph Hellwig Subject: Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header Message-ID: <20121123124119.GC12150@infradead.org> References: <1352721264-3700-1-git-send-email-david@fromorbit.com> <1352721264-3700-9-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1352721264-3700-9-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Mon, Nov 12, 2012 at 10:54:00PM +1100, Dave Chinner wrote: > From: Dave Chinner > > For verification purposes, AGFLs need to be initialised to a known > set of values. For upcoming CRC changes, they are also headers that > need to be initialised. Currently, growfs does neither for the AGFLs > - it ignores them completely. Add initialisation of the AGFL to be > full of invalid block numbers (NULLAGBLOCK) to put the > infrastructure in place needed for CRC support. > > Includes a comment clarification from Jeff Liu. Looks good. If you plan to touch this code even more I'd suggst splitting out a helper for each kinda of block / header that is initialized from xfs_growfs_data_private. Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs